8252957: Wrong comment in CgroupV1Subsystem::cpu_quota

Jonathan Dowland · Jonathan Dowland · commit 0662db27bf72 · 2022-12-16T14:30:24.000Z
The comment is wrong. The 'us' in 'cpu.cfs_quota_us' stands for
microseconds, which is read verbatim. Similarly for cgroups v2
all units in 'cpu.max' are in microseconds.

Backport-of: 5166094647f8bfae32ef4bbde2e40f68e073b595
diff --git a/hotspot/src/os/linux/vm/cgroupV1Subsystem_linux.cpp b/hotspot/src/os/linux/vm/cgroupV1Subsystem_linux.cpp
@@ -212,11 +212,11 @@ char * CgroupV1Subsystem::cpu_cpuset_memory_nodes() {
 
 /* cpu_quota
  *
- * Return the number of milliseconds per period
+ * Return the number of microseconds per period
  * process is guaranteed to run.
  *
  * return:
- *    quota time in milliseconds
+ *    quota time in microseconds
  *    -1 for no quota
  *    OSCONTAINER_ERROR for not supported
  */
diff --git a/hotspot/src/os/linux/vm/cgroupV2Subsystem_linux.cpp b/hotspot/src/os/linux/vm/cgroupV2Subsystem_linux.cpp
@@ -82,11 +82,11 @@ int CgroupV2Subsystem::cpu_shares() {
 
 /* cpu_quota
  *
- * Return the number of milliseconds per period
+ * Return the number of microseconds per period
  * process is guaranteed to run.
  *
  * return:
- *    quota time in milliseconds
+ *    quota time in microseconds
  *    -1 for no quota
  *    OSCONTAINER_ERROR for not supported
  */

Original file line number	Diff line number	Diff line change
`@@ -212,11 +212,11 @@ char * CgroupV1Subsystem::cpu_cpuset_memory_nodes() {`
`212`	`212`
`213`	`213`	`/* cpu_quota`
`214`	`214`	`*`
`215`		`- * Return the number of milliseconds per period`
	`215`	`+ * Return the number of microseconds per period`
`216`	`216`	`* process is guaranteed to run.`
`217`	`217`	`*`
`218`	`218`	`* return:`
`219`		`- * quota time in milliseconds`
	`219`	`+ * quota time in microseconds`
`220`	`220`	`* -1 for no quota`
`221`	`221`	`* OSCONTAINER_ERROR for not supported`
`222`	`222`	`*/`
Original file line number	Diff line number	Diff line change
`@@ -82,11 +82,11 @@ int CgroupV2Subsystem::cpu_shares() {`
`82`	`82`
`83`	`83`	`/* cpu_quota`
`84`	`84`	`*`
`85`		`- * Return the number of milliseconds per period`
	`85`	`+ * Return the number of microseconds per period`
`86`	`86`	`* process is guaranteed to run.`
`87`	`87`	`*`
`88`	`88`	`* return:`
`89`		`- * quota time in milliseconds`
	`89`	`+ * quota time in microseconds`
`90`	`90`	`* -1 for no quota`
`91`	`91`	`* OSCONTAINER_ERROR for not supported`
`92`	`92`	`*/`