Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hat performance minimize buffer copy tweaking #348

Conversation

grfrost
Copy link
Collaborator

@grfrost grfrost commented Mar 12, 2025

Buffer marking seems to work

Get perf improvement on game of life (x2.5) mandel (x0.25 ish) and suprisingly on violajones.

To compare with and without use env vars

HAT=GPU,MINIMIZE_COPIES java @bldr/hatrun ffi-opencl life

vs

HAT=GPU java @bldr/hatrun ffi-opencl life

Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/348/head:pull/348
$ git checkout pull/348

Update a local copy of the PR:
$ git checkout pull/348
$ git pull https://git.openjdk.org/babylon.git pull/348/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 348

View PR using the GUI difftool:
$ git pr show -t 348

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/348.diff

Sorry, something went wrong.

@grfrost
Copy link
Collaborator Author

grfrost commented Mar 12, 2025

/integrate

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 12, 2025

👋 Welcome back gfrost! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 12, 2025

@grfrost This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Hat performance minimize buffer copy tweaking

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the code-reflection branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the code-reflection branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 12, 2025
@openjdk
Copy link

openjdk bot commented Mar 12, 2025

Going to push as commit 73274d5.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 12, 2025
@openjdk openjdk bot closed this Mar 12, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 12, 2025
@openjdk
Copy link

openjdk bot commented Mar 12, 2025

@grfrost Pushed as commit 73274d5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Mar 12, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

1 participant