New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print peristent JAR assumptions #38
Conversation
👋 Welcome back akozlov! A progress list of the required criteria for merging this PR into |
@AntonKozlov This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks straight forward
Thanks for review! |
/integrate |
Going to push as commit 65e0785. |
@AntonKozlov Pushed as commit 65e0785. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
When an application creates URLClassLoader with the JAR, the JAR file will be assumed persistent, that is, it should be available on the restore. To make this more evident, the PR adds reporting for such JARs.
I'm not a big fan of persistent files and the implications, I think it may be done better, but while they are there, better to make them more usable.
Progress
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac pull/38/head:pull/38
$ git checkout pull/38
Update a local copy of the PR:
$ git checkout pull/38
$ git pull https://git.openjdk.org/crac pull/38/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 38
View PR using the GUI difftool:
$ git pr show -t 38
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/crac/pull/38.diff