Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More information on fix version usage #128

Closed
wants to merge 6 commits into from
+49 −26
Closed

More information on fix version usage #128

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4369388
More information on fix version usage
JesperIRL Jun 18, 2024
fff63d4
Fixed linebreaks
JesperIRL Jun 18, 2024
b7a8bb5
Comment on affects version
JesperIRL Jun 18, 2024
14a857a
Fixes after review
JesperIRL Jun 18, 2024
bb46b80
Fixed grammar
JesperIRL Jun 26, 2024
a889a7a
Merge branch 'master' into cleanups
JesperIRL Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/guide/jbs-jdk-bug-system.md
View file
Original file line number Diff line number Diff line change
@@ -261,7 +261,7 @@ Some additional fields should be filled out or updated as you get a better under

## Resolving or Closing an issue

Once the work on an issue has been completed the issues [Status]{.jbs-field} should be in a "completed" state. There are two "completed" states: [Resolved]{.jbs-value} and [Closed]{.jbs-value}. These are accompanied by a [Resolution]{.jbs-field} and a [Fix Version/s]{.jbs-value}. Which combination of [Status]{.jbs-field}, [Resolution]{.jbs-field}, and [Fix Version/s]{.jbs-value} you should use depends on how the issue is completed.
Once the work on an issue has been completed the issue's [Status]{.jbs-field} should be in a "completed" state. There are two "completed" states: [Resolved]{.jbs-value} and [Closed]{.jbs-value}. These are accompanied by a [Resolution]{.jbs-field} and a [Fix Version/s]{.jbs-value}. Which combination of [Status]{.jbs-field}, [Resolution]{.jbs-field}, and [Fix Version/s]{.jbs-value} you should use depends on how the issue is completed.

Most resolutions are used to close an issue so that it ends up being [Closed]{.jbs-value} directly, but resolutions that indicates that a change has been integrated into a Project repository must go through the [Resolved]{.jbs-value} state. An issue in [Resolved]{.jbs-value} state needs to go through [verification](#verifying-an-issue) to end up as [Closed]{.jbs-value}. For the JDK project in almost all cases the bots will transition the issue to [Resolved]{.jbs-value}/[Fixed]{.jbs-value} when the changeset is integrated to the repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"needs to go through"
is it more "may go through"?

Copy link
Member Author

@JesperIRL JesperIRL Jun 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it may go through verification, but it needs to go through verification to end up as Closed. I guess both works. I have no strong opinion.


@@ -294,7 +294,7 @@ When an issue is closed as [Won't Fix]{.jbs-value}, do not remove the [Fix Versi
:::

:::{.note}
The fix version [na]{.jbs-value} should only be used on backport issues that was created by mistake. See [How to fix an incorrect backport creation in JBS].
The fix version [na]{.jbs-value} should only be used on backport issues that is created by mistake. See [How to fix an incorrect backport creation in JBS].
:::

### Closing issues without knowing what fixed it