Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7903320: Move InvokeMethodAdapter.getInvokeID(String, String, String) up #26

Closed
wants to merge 1 commit into from
Closed

7903320: Move InvokeMethodAdapter.getInvokeID(String, String, String) up #26

wants to merge 1 commit into from

Conversation

shurymury
Copy link
Collaborator

@shurymury shurymury commented Sep 20, 2022

CODETOOLS-7903320: Move InvokeMethodAdapter.getInvokeID(String, String, String) up

Next change to isolate ASM usage.


Progress

  • Change must not contain extraneous whitespace

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jcov pull/26/head:pull/26
$ git checkout pull/26

Update a local copy of the PR:
$ git checkout pull/26
$ git pull https://git.openjdk.org/jcov pull/26/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26

View PR using the GUI difftool:
$ git pr show -t 26

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jcov/pull/26.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 20, 2022

👋 Welcome back shurailine! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title CODETOOLS-7903320: Move InvokeMethodAdapter.getInvokeID(String, Strin… 7903320: Move InvokeMethodAdapter.getInvokeID(String, String, String) up Sep 20, 2022
@openjdk
Copy link

openjdk bot commented Sep 20, 2022

@shurymury This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7903320: Move InvokeMethodAdapter.getInvokeID(String, String, String) up

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Ready to be integrated rfr Ready for review labels Sep 20, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 20, 2022

Webrevs

@lkuskov
Copy link
Collaborator

lkuskov commented Sep 21, 2022

No objections. LGTM

@shurymury
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 21, 2022

Going to push as commit c619b66.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 21, 2022
@openjdk openjdk bot closed this Sep 21, 2022
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Sep 21, 2022
@openjdk
Copy link

openjdk bot commented Sep 21, 2022

@shurymury Pushed as commit c619b66.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants