Skip to content

Commit 4a1cdd5

Browse files
committedJun 4, 2024
8333486: Parallel: Remove unused methods in psParallelCompact
Reviewed-by: tschatzl
1 parent 664c993 commit 4a1cdd5

File tree

2 files changed

+10
-27
lines changed

2 files changed

+10
-27
lines changed
 

‎src/hotspot/share/gc/parallel/psParallelCompact.cpp

-15
Original file line numberDiff line numberDiff line change
@@ -280,21 +280,6 @@ PSParallelCompact::print_generic_summary_data(ParallelCompactData& summary_data,
280280
::print_generic_summary_data(summary_data,beg_addr, end_addr);
281281
}
282282

283-
void
284-
print_generic_summary_data(ParallelCompactData& summary_data,
285-
SpaceInfo* space_info)
286-
{
287-
if (!log_develop_is_enabled(Trace, gc, compaction)) {
288-
return;
289-
}
290-
291-
for (unsigned int id = 0; id < PSParallelCompact::last_space_id; ++id) {
292-
const MutableSpace* space = space_info[id].space();
293-
print_generic_summary_data(summary_data, space->bottom(),
294-
MAX2(space->top(), space_info[id].new_top()));
295-
}
296-
}
297-
298283
static void
299284
print_initial_summary_data(ParallelCompactData& summary_data,
300285
const MutableSpace* space) {

‎src/hotspot/share/gc/parallel/psParallelCompact.hpp

+10-12
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ inline bool SplitInfo::is_split(size_t region_idx) const
166166

167167
class SpaceInfo
168168
{
169-
public:
169+
public:
170170
MutableSpace* space() const { return _space; }
171171

172172
// Where the free space will start after the collection. Valid only after the
@@ -190,9 +190,7 @@ class SpaceInfo
190190
void set_dense_prefix(HeapWord* addr) { _dense_prefix = addr; }
191191
void set_start_array(ObjectStartArray* s) { _start_array = s; }
192192

193-
void publish_new_top() const { _space->set_top(_new_top); }
194-
195-
private:
193+
private:
196194
MutableSpace* _space;
197195
HeapWord* _new_top;
198196
HeapWord* _dense_prefix;
@@ -681,7 +679,7 @@ ParallelCompactData::is_region_aligned(HeapWord* addr) const
681679
// https://doi.org/10.1145/3313808.3313820
682680

683681
class PSParallelCompact : AllStatic {
684-
public:
682+
public:
685683
// Convenient access to type names.
686684
typedef ParMarkBitMap::idx_t idx_t;
687685
typedef ParallelCompactData::RegionData RegionData;
@@ -701,7 +699,7 @@ class PSParallelCompact : AllStatic {
701699

702700
friend class PSParallelCompactTest;
703701

704-
private:
702+
private:
705703
static STWGCTimer _gc_timer;
706704
static ParallelOldTracer _gc_tracer;
707705
static elapsedTimer _accumulated_time;
@@ -716,10 +714,10 @@ class PSParallelCompact : AllStatic {
716714
static SpanSubjectToDiscoveryClosure _span_based_discoverer;
717715
static ReferenceProcessor* _ref_processor;
718716

719-
public:
717+
public:
720718
static ParallelOldTracer* gc_tracer() { return &_gc_tracer; }
721719

722-
private:
720+
private:
723721

724722
static void initialize_space_info();
725723

@@ -768,7 +766,7 @@ class PSParallelCompact : AllStatic {
768766

769767
static void fill_range_in_dense_prefix(HeapWord* start, HeapWord* end);
770768

771-
public:
769+
public:
772770
static void fill_dead_objs_in_dense_prefix(uint worker_id, uint num_workers);
773771

774772
static bool invoke(bool maximum_heap_compaction);
@@ -885,12 +883,12 @@ class PSParallelCompact : AllStatic {
885883
};
886884

887885
class MoveAndUpdateClosure: public StackObj {
888-
private:
886+
private:
889887
ParMarkBitMap* const _bitmap;
890888
size_t _words_remaining; // Words left to copy.
891889
static inline size_t calculate_words_remaining(size_t region);
892890

893-
protected:
891+
protected:
894892
HeapWord* _source; // Next addr that would be read.
895893
HeapWord* _destination; // Next addr to be written.
896894
ObjectStartArray* const _start_array;
@@ -900,7 +898,7 @@ class MoveAndUpdateClosure: public StackObj {
900898
// Update variables to indicate that word_count words were processed.
901899
inline void update_state(size_t words);
902900

903-
public:
901+
public:
904902
typedef ParMarkBitMap::idx_t idx_t;
905903

906904
ParMarkBitMap* bitmap() const { return _bitmap; }

1 commit comments

Comments
 (1)

openjdk-notifier[bot] commented on Jun 4, 2024

@openjdk-notifier[bot]
Please sign in to comment.