Skip to content

Commit 6e3cc13

Browse files
committedAug 9, 2023
8312467: relax the builddir check in make/autoconf/basic.m4
Reviewed-by: clanger, erikj
1 parent 77e5739 commit 6e3cc13

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed
 

‎make/autoconf/basic.m4

+6-5
Original file line numberDiff line numberDiff line change
@@ -406,9 +406,9 @@ AC_DEFUN_ONCE([BASIC_SETUP_OUTPUT_DIR],
406406
# WARNING: This might be a bad thing to do. You need to be sure you want to
407407
# have a configuration in this directory. Do some sanity checks!
408408
409-
if test ! -e "$OUTPUTDIR/spec.gmk"; then
410-
# If we have a spec.gmk, we have run here before and we are OK. Otherwise, check for
411-
# other files
409+
if test ! -e "$OUTPUTDIR/spec.gmk" && test ! -e "$OUTPUTDIR/configure-support/generated-configure.sh"; then
410+
# If we have a spec.gmk or configure-support/generated-configure.sh,
411+
# we have run here before and we are OK. Otherwise, check for other files
412412
files_present=`$LS $OUTPUTDIR`
413413
# Configure has already touched config.log and confdefs.h in the current dir when this check
414414
# is performed.
@@ -423,8 +423,9 @@ AC_DEFUN_ONCE([BASIC_SETUP_OUTPUT_DIR],
423423
AC_MSG_NOTICE([Current directory is $CONFIGURE_START_DIR.])
424424
AC_MSG_NOTICE([Since this is not the source root, configure will output the configuration here])
425425
AC_MSG_NOTICE([(as opposed to creating a configuration in <src_root>/build/<conf-name>).])
426-
AC_MSG_NOTICE([However, this directory is not empty. This is not allowed, since it could])
427-
AC_MSG_NOTICE([seriously mess up just about everything.])
426+
AC_MSG_NOTICE([However, this directory is not empty, additionally to some allowed files])
427+
AC_MSG_NOTICE([it contains $filtered_files.])
428+
AC_MSG_NOTICE([This is not allowed, since it could seriously mess up just about everything.])
428429
AC_MSG_NOTICE([Try 'cd $TOPDIR' and restart configure])
429430
AC_MSG_NOTICE([(or create a new empty directory and cd to it).])
430431
AC_MSG_ERROR([Will not continue creating configuration in $CONFIGURE_START_DIR])

5 commit comments

Comments
 (5)

openjdk-notifier[bot] commented on Aug 9, 2023

@openjdk-notifier[bot]

MBaesken commented on Oct 9, 2023

@MBaesken
MemberAuthor

/backport jdk21u

openjdk[bot] commented on Oct 9, 2023

@openjdk[bot]

@MBaesken the backport was successfully created on the branch MBaesken-backport-6e3cc131 in my personal fork of openjdk/jdk21u. To create a pull request with this backport targeting openjdk/jdk21u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 6e3cc131 from the openjdk/jdk repository.

The commit being backported was authored by Matthias Baesken on 9 Aug 2023 and was reviewed by Christoph Langer and Erik Joelsson.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u:

$ git fetch https://github.com/openjdk-bots/jdk21u.git MBaesken-backport-6e3cc131:MBaesken-backport-6e3cc131
$ git checkout MBaesken-backport-6e3cc131
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u.git MBaesken-backport-6e3cc131

MBaesken commented on Oct 31, 2023

@MBaesken
MemberAuthor

/backport jdk17u-dev

openjdk[bot] commented on Oct 31, 2023

@openjdk[bot]

@MBaesken the backport was successfully created on the branch MBaesken-backport-6e3cc131 in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 6e3cc131 from the openjdk/jdk repository.

The commit being backported was authored by Matthias Baesken on 9 Aug 2023 and was reviewed by Christoph Langer and Erik Joelsson.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev.git MBaesken-backport-6e3cc131:MBaesken-backport-6e3cc131
$ git checkout MBaesken-backport-6e3cc131
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev.git MBaesken-backport-6e3cc131
Please sign in to comment.