Navigation Menu

Skip to content

Commit

Permalink
8285836: sun/net/www/http/KeepAliveCache/KeepAliveProperty.java faile…
Browse files Browse the repository at this point in the history 
…d with "RuntimeException: Failed in server"

Reviewed-by: dfuchs, jpai
  • Loading branch information
@djelinski
djelinski committed Aug 3, 2022
1 parent b7d2bde commit af529be
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion test/jdk/sun/net/www/http/KeepAliveCache/KeepAliveProperty.java
View file
Expand Up @@ -40,6 +40,7 @@
public class KeepAliveProperty {

static volatile boolean pass = false;
static Logger logger = Logger.getLogger("sun.net.www.protocol.http.HttpURLConnection");

static class Server extends Thread {
final ServerSocket server;
Expand Down Expand Up @@ -138,7 +139,6 @@ static String fetch(URL url) throws Exception {

public static void main(String args[]) throws Exception {
// exercise the logging code
Logger logger = Logger.getLogger("sun.net.www.protocol.http.HttpURLConnection");
logger.setLevel(Level.FINEST);
ConsoleHandler h = new ConsoleHandler();
h.setLevel(Level.FINEST);
Expand Down Expand Up @@ -171,6 +171,7 @@ public static void main(String args[]) throws Exception {
if (!expectClose)
throw e;
}
s.join();

if (!pass)
throw new RuntimeException("Failed in server");
Expand Down

5 comments on commit af529be

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on af529be Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on af529be Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch GoeLin-backport-af529be0 in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit af529be0 from the openjdk/jdk repository.

The commit being backported was authored by Daniel Jeliński on 3 Aug 2022 and was reviewed by Daniel Fuchs and Jaikiran Pai.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev GoeLin-backport-af529be0:GoeLin-backport-af529be0
$ git checkout GoeLin-backport-af529be0
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev GoeLin-backport-af529be0

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on af529be Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on af529be Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch GoeLin-backport-af529be0 in my personal fork of openjdk/jdk11u-dev. To create a pull request with this backport targeting openjdk/jdk11u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit af529be0 from the openjdk/jdk repository.

The commit being backported was authored by Daniel Jeliński on 3 Aug 2022 and was reviewed by Daniel Fuchs and Jaikiran Pai.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk11u-dev:

$ git fetch https://github.com/openjdk-bots/jdk11u-dev GoeLin-backport-af529be0:GoeLin-backport-af529be0
$ git checkout GoeLin-backport-af529be0
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk11u-dev GoeLin-backport-af529be0

Please sign in to comment.