Skip to content

Commit ba69ed7

Browse files
committedAug 13, 2024
8338202: Shenandoah: Improve handshake closure labels
Reviewed-by: rkennke, ysr, wkemper
1 parent 5bf2709 commit ba69ed7

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed
 

‎src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -823,7 +823,7 @@ void ShenandoahConcurrentGC::op_weak_roots() {
823823
// Perform handshake to flush out dead oops
824824
{
825825
ShenandoahTimingsTracker t(ShenandoahPhaseTimings::conc_weak_roots_rendezvous);
826-
heap->rendezvous_threads();
826+
heap->rendezvous_threads("Shenandoah Concurrent Weak Roots");
827827
}
828828
}
829829

‎src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ class ShenandoahFlushSATBHandshakeClosure : public HandshakeClosure {
179179
SATBMarkQueueSet& _qset;
180180
public:
181181
ShenandoahFlushSATBHandshakeClosure(SATBMarkQueueSet& qset) :
182-
HandshakeClosure("Shenandoah Flush SATB Handshake"),
182+
HandshakeClosure("Shenandoah Flush SATB"),
183183
_qset(qset) {}
184184

185185
void do_thread(Thread* thread) {

‎src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -1744,12 +1744,12 @@ void ShenandoahHeap::parallel_heap_region_iterate(ShenandoahHeapRegionClosure* b
17441744

17451745
class ShenandoahRendezvousClosure : public HandshakeClosure {
17461746
public:
1747-
inline ShenandoahRendezvousClosure() : HandshakeClosure("ShenandoahRendezvous") {}
1747+
inline ShenandoahRendezvousClosure(const char* name) : HandshakeClosure(name) {}
17481748
inline void do_thread(Thread* thread) {}
17491749
};
17501750

1751-
void ShenandoahHeap::rendezvous_threads() {
1752-
ShenandoahRendezvousClosure cl;
1751+
void ShenandoahHeap::rendezvous_threads(const char* name) {
1752+
ShenandoahRendezvousClosure cl(name);
17531753
Handshake::execute(&cl);
17541754
}
17551755

‎src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,7 @@ class ShenandoahHeap : public CollectedHeap, public ShenandoahSpaceInfo {
400400
void update_heap_region_states(bool concurrent);
401401
void rebuild_free_set(bool concurrent);
402402

403-
void rendezvous_threads();
403+
void rendezvous_threads(const char* name);
404404
void recycle_trash();
405405
public:
406406
void notify_gc_progress();

‎src/hotspot/share/gc/shenandoah/shenandoahUnload.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ void ShenandoahUnload::unload() {
168168
// Make sure stale metadata and nmethods are no longer observable
169169
{
170170
ShenandoahTimingsTracker t(ShenandoahPhaseTimings::conc_class_unload_rendezvous);
171-
heap->rendezvous_threads();
171+
heap->rendezvous_threads("Shenandoah Class Unloading");
172172
}
173173

174174
// Purge stale metadata and nmethods that were unlinked

0 commit comments

Comments
 (0)