Skip to content

Commit

Permalink
8295412: support latest VS2022 MSC_VER in abstract_vm_version.cpp
Browse files Browse the repository at this point in the history 
Reviewed-by: dholmes, lucy
  • Loading branch information
@MBaesken
MBaesken committed Oct 18, 2022
1 parent c33ca0c commit bca7ab3
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/hotspot/share/runtime/abstract_vm_version.cpp
View file
Expand Up @@ -239,6 +239,10 @@ const char* Abstract_VM_Version::internal_vm_info_string() {
#define HOTSPOT_BUILD_COMPILER "MS VC++ 17.0 (VS2022)"
#elif _MSC_VER == 1931
#define HOTSPOT_BUILD_COMPILER "MS VC++ 17.1 (VS2022)"
#elif _MSC_VER == 1932
#define HOTSPOT_BUILD_COMPILER "MS VC++ 17.2 (VS2022)"
#elif _MSC_VER == 1933
#define HOTSPOT_BUILD_COMPILER "MS VC++ 17.3 (VS2022)"
#else
#define HOTSPOT_BUILD_COMPILER "unknown MS VC++:" XSTR(_MSC_VER)
#endif
Expand Down

5 comments on commit bca7ab3

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@MBaesken
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on bca7ab3 Oct 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MBaesken the backport was successfully created on the branch MBaesken-backport-bca7ab3c in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit bca7ab3c from the openjdk/jdk repository.

The commit being backported was authored by Matthias Baesken on 18 Oct 2022 and was reviewed by David Holmes and Lutz Schmidt.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev MBaesken-backport-bca7ab3c:MBaesken-backport-bca7ab3c
$ git checkout MBaesken-backport-bca7ab3c
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev MBaesken-backport-bca7ab3c

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on bca7ab3 Jan 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on bca7ab3 Jan 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch GoeLin-backport-bca7ab3c in my personal fork of openjdk/jdk11u-dev. To create a pull request with this backport targeting openjdk/jdk11u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit bca7ab3c from the openjdk/jdk repository.

The commit being backported was authored by Matthias Baesken on 18 Oct 2022 and was reviewed by David Holmes and Lutz Schmidt.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk11u-dev:

$ git fetch https://github.com/openjdk-bots/jdk11u-dev GoeLin-backport-bca7ab3c:GoeLin-backport-bca7ab3c
$ git checkout GoeLin-backport-bca7ab3c
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk11u-dev GoeLin-backport-bca7ab3c

Please sign in to comment.