Skip to content

Commit d90b79a

Browse files
committedMar 10, 2025
8351046: Rename ObjectMonitor functions
Reviewed-by: stefank, fbredberg
1 parent e90b6bd commit d90b79a

File tree

4 files changed

+135
-135
lines changed

4 files changed

+135
-135
lines changed
 

‎src/hotspot/share/runtime/objectMonitor.cpp

+113-113
Large diffs are not rendered by default.

‎src/hotspot/share/runtime/objectMonitor.hpp

+18-18
Original file line numberDiff line numberDiff line change
@@ -203,9 +203,9 @@ class ObjectMonitor : public CHeapObj<mtObjectMonitor> {
203203
// deflated. It is also used by the async deflation protocol. See
204204
// ObjectMonitor::deflate_monitor().
205205

206-
ObjectWaiter* volatile _WaitSet; // LL of threads wait()ing on the monitor
206+
ObjectWaiter* volatile _wait_set; // LL of threads waiting on the monitor - wait()
207207
volatile int _waiters; // number of waiting threads
208-
volatile int _WaitSetLock; // protects Wait Queue - simple spinlock
208+
volatile int _wait_set_lock; // protects wait set queue - simple spinlock
209209

210210
// Used in LM_LEGACY mode to store BasicLock* in case of inflation by contending thread.
211211
BasicLock* volatile _stack_locker;
@@ -375,7 +375,7 @@ class ObjectMonitor : public CHeapObj<mtObjectMonitor> {
375375

376376
// JVM/TI GetObjectMonitorUsage() needs this:
377377
int waiters() const;
378-
ObjectWaiter* first_waiter() { return _WaitSet; }
378+
ObjectWaiter* first_waiter() { return _wait_set; }
379379
ObjectWaiter* next_waiter(ObjectWaiter* o) { return o->_next; }
380380
JavaThread* thread_of_waiter(ObjectWaiter* o) { return o->_thread; }
381381

@@ -435,29 +435,29 @@ class ObjectMonitor : public CHeapObj<mtObjectMonitor> {
435435

436436
private:
437437
void add_to_entry_list(JavaThread* current, ObjectWaiter* node);
438-
void AddWaiter(ObjectWaiter* waiter);
439-
void INotify(JavaThread* current);
440-
ObjectWaiter* DequeueWaiter();
441-
void DequeueSpecificWaiter(ObjectWaiter* waiter);
442-
void EnterI(JavaThread* current);
443-
void ReenterI(JavaThread* current, ObjectWaiter* current_node);
444-
void UnlinkAfterAcquire(JavaThread* current, ObjectWaiter* current_node);
438+
void add_waiter(ObjectWaiter* waiter);
439+
void notify_internal(JavaThread* current);
440+
ObjectWaiter* dequeue_waiter();
441+
void dequeue_specific_waiter(ObjectWaiter* waiter);
442+
void enter_internal(JavaThread* current);
443+
void reenter_internal(JavaThread* current, ObjectWaiter* current_node);
444+
void unlink_after_acquire(JavaThread* current, ObjectWaiter* current_node);
445445
ObjectWaiter* entry_list_tail(JavaThread* current);
446446

447-
bool VThreadMonitorEnter(JavaThread* current, ObjectWaiter* node = nullptr);
448-
void VThreadWait(JavaThread* current, jlong millis);
449-
bool VThreadWaitReenter(JavaThread* current, ObjectWaiter* node, ContinuationWrapper& cont);
450-
void VThreadEpilog(JavaThread* current, ObjectWaiter* node);
447+
bool vthread_monitor_enter(JavaThread* current, ObjectWaiter* node = nullptr);
448+
void vthread_wait(JavaThread* current, jlong millis);
449+
bool vthread_wait_reenter(JavaThread* current, ObjectWaiter* node, ContinuationWrapper& cont);
450+
void vthread_epilog(JavaThread* current, ObjectWaiter* node);
451451

452452
enum class TryLockResult { Interference = -1, HasOwner = 0, Success = 1 };
453453

454-
bool TryLockWithContentionMark(JavaThread* locking_thread, ObjectMonitorContentionMark& contention_mark);
454+
bool try_lock_with_contention_mark(JavaThread* locking_thread, ObjectMonitorContentionMark& contention_mark);
455455
bool try_lock_or_add_to_entry_list(JavaThread* current, ObjectWaiter* node);
456-
TryLockResult TryLock(JavaThread* current);
456+
TryLockResult try_lock(JavaThread* current);
457457

458-
bool TrySpin(JavaThread* current);
458+
bool try_spin(JavaThread* current);
459459
bool short_fixed_spin(JavaThread* current, int spin_count, bool adapt);
460-
void ExitEpilog(JavaThread* current, ObjectWaiter* Wakee);
460+
void exit_epilog(JavaThread* current, ObjectWaiter* Wakee);
461461

462462
// Deflation support
463463
bool deflate_monitor(Thread* current);

‎src/hotspot/share/runtime/objectMonitor.inline.hpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 1998, 2024, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 1998, 2025, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* This code is free software; you can redistribute it and/or modify it
@@ -249,7 +249,7 @@ inline ObjectMonitorContentionMark::ObjectMonitorContentionMark(ObjectMonitor* m
249249
// contended enter protocol, which prevents the deflater thread from
250250
// winning the last part of the 2-part async deflation
251251
// protocol. See: ObjectMonitor::deflate_monitor() and
252-
// ObjectMonitor::TryLockWithContentionMark().
252+
// ObjectMonitor::try_lock_with_contention_mark().
253253
_monitor->add_to_contentions(1);
254254
}
255255

@@ -261,7 +261,7 @@ inline ObjectMonitorContentionMark::~ObjectMonitorContentionMark() {
261261
}
262262

263263
inline void ObjectMonitorContentionMark::extend() {
264-
// Used by ObjectMonitor::TryLockWithContentionMark() to "extend the
264+
// Used by ObjectMonitor::try_lock_with_contention_mark() to "extend the
265265
// lifetime" of the contention mark.
266266
assert(!_extended, "extending twice is probably a bad design");
267267
_monitor->add_to_contentions(1);

‎src/hotspot/share/runtime/synchronizer.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -374,7 +374,7 @@ bool ObjectSynchronizer::quick_notify(oopDesc* obj, JavaThread* current, bool al
374374
}
375375
int free_count = 0;
376376
do {
377-
mon->INotify(current);
377+
mon->notify_internal(current);
378378
++free_count;
379379
} while (mon->first_waiter() != nullptr && all);
380380
OM_PERFDATA_OP(Notifications, inc(free_count));

1 commit comments

Comments
 (1)

openjdk-notifier[bot] commented on Mar 10, 2025

@openjdk-notifier[bot]
Please sign in to comment.