Skip to content

Commit

Permalink
8288173: JDK-8202449 fix causes conformance test failure : api/java_u…
Browse files Browse the repository at this point in the history 
…til/Random/RandomGenerator/NextFloat.html

Reviewed-by: bpb, darcy
  • Loading branch information
@rgiulietti
rgiulietti authored and Brian Burkhalter committed Jun 10, 2022
1 parent f2e10dc commit da2339c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/java.base/share/classes/jdk/internal/util/random/RandomSupport.java
View file
Expand Up @@ -733,7 +733,7 @@ public static float boundedNextFloat(RandomGenerator rng, float origin, float bo
r = (r * (0.5f * bound - halfOrigin) + halfOrigin) * 2.0f;
}
if (r >= bound) // may need to correct a rounding problem
r = Math.nextDown(r);
r = Math.nextDown(bound);
}
return r;
}
Expand Down Expand Up @@ -765,7 +765,7 @@ public static float boundedNextFloat(RandomGenerator rng, float bound) {
float r = rng.nextFloat();
r = r * bound;
if (r >= bound) // may need to correct a rounding problem
r = Math.nextDown(r);
r = Math.nextDown(bound);
return r;
}

Expand Down

3 comments on commit da2339c

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@jddarcy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk19

@openjdk
Copy link

@openjdk openjdk bot commented on da2339c Jun 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jddarcy the backport was successfully created on the branch jddarcy-backport-da2339cf in my personal fork of openjdk/jdk19. To create a pull request with this backport targeting openjdk/jdk19:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit da2339cf from the openjdk/jdk repository.

The commit being backported was authored by Raffaello Giulietti on 10 Jun 2022 and was reviewed by Brian Burkhalter and Joe Darcy.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk19:

$ git fetch https://github.com/openjdk-bots/jdk19 jddarcy-backport-da2339cf:jddarcy-backport-da2339cf
$ git checkout jddarcy-backport-da2339cf
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk19 jddarcy-backport-da2339cf

Please sign in to comment.