8344976: Remove the jmx.invoke.getters compatibility property

Reviewed-by: cjplummer, dfuchs, sspitsyn

Author: kevinjwalls

src/java.management/share/classes/com/sun/jmx/mbeanserver/PerInterface.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2005, 2024, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2005, 2025, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -108,8 +108,7 @@ Object invoke(Object resource, String operation, Object[] params,
         final List<MethodAndSig> list = ops.get(operation);
         if (list == null) {
             final String msg = "No such operation: " + operation;
-            return noSuchMethod(msg, resource, operation, params, signature,
-                                cookie);
+            throw new ReflectionException(new NoSuchMethodException(operation + sigString(signature)), msg);
         }
         if (signature == null)
             signature = new String[0];
@@ -131,83 +130,11 @@ Object invoke(Object resource, String operation, Object[] params,
                 msg = "Operation " + operation + " exists but not with " +
                         "this signature: " + badSig;
             }
-            return noSuchMethod(msg, resource, operation, params, signature,
-                                cookie);
+            throw new ReflectionException(new NoSuchMethodException(operation + badSig), msg);
         }
         return introspector.invokeM(found.method, resource, params, cookie);
     }
 
-    /*
-     * This method is called when invoke doesn't find the named method.
-     * Before throwing an exception, we check to see whether the
-     * jmx.invoke.getters property is set, and if so whether the method
-     * being invoked might be a getter or a setter.  If so we invoke it
-     * and return the result.  This is for compatibility
-     * with code based on JMX RI 1.0 or 1.1 which allowed invoking getters
-     * and setters.  It is *not* recommended that new code use this feature.
-     *
-     * Since this method is either going to throw an exception or use
-     * functionality that is strongly discouraged, we consider that its
-     * performance is not very important.
-     *
-     * A simpler way to implement the functionality would be to add the getters
-     * and setters to the operations map when jmx.invoke.getters is set.
-     * However, that means that the property is consulted when an MBean
-     * interface is being introspected and not thereafter.  Previously,
-     * the property was consulted on every invocation.  So this simpler
-     * implementation could potentially break code that sets and unsets
-     * the property at different times.
-     */
-    @SuppressWarnings("removal")
-    private Object noSuchMethod(String msg, Object resource, String operation,
-                                Object[] params, String[] signature,
-                                Object cookie)
-            throws MBeanException, ReflectionException {
-
-        // Construct the exception that we will probably throw
-        final NoSuchMethodException nsme =
-            new NoSuchMethodException(operation + sigString(signature));
-        final ReflectionException exception =
-            new ReflectionException(nsme, msg);
-
-        if (introspector.isMXBean())
-            throw exception; // No compatibility requirement here
-
-        // Is the compatibility property set?
-        String invokeGettersS = System.getProperty("jmx.invoke.getters");
-        if (invokeGettersS == null)
-            throw exception;
-
-        int rest = 0;
-        Map<String, M> methods = null;
-        if (signature == null || signature.length == 0) {
-            if (operation.startsWith("get"))
-                rest = 3;
-            else if (operation.startsWith("is"))
-                rest = 2;
-            if (rest != 0)
-                methods = getters;
-        } else if (signature.length == 1 &&
-                   operation.startsWith("set")) {
-            rest = 3;
-            methods = setters;
-        }
-
-        if (rest != 0) {
-            String attrName = operation.substring(rest);
-            M method = methods.get(attrName);
-            if (method != null && introspector.getName(method).equals(operation)) {
-                String[] msig = introspector.getSignature(method);
-                if ((signature == null && msig.length == 0) ||
-                        Arrays.equals(signature, msig)) {
-                    return introspector.invokeM(method, resource, params, cookie);
-                }
-            }
-        }
-
-        throw exception;
-    }
-
     private String sigString(String[] signature) {
         StringBuilder b = new StringBuilder("(");
         if (signature != null) {

test/jdk/javax/management/Introspector/InvokeGettersTest.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2005, 2015, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2005, 2025, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -23,8 +23,8 @@
 
 /*
  * @test
- * @bug 6317101
- * @summary Test that the jmx.invoke.getters system property works
+ * @bug 6317101 8344976
+ * @summary Test invocation after removal of the jmx.invoke.getters system property
  * @author Eamonn McManus
  *
  * @run clean InvokeGettersTest
@@ -63,10 +63,7 @@ public static void main(String[] args) throws Exception {
         ObjectName on = new ObjectName("a:b=c");
         mbs.registerMBean(new Thing(), on);
         if (test(mbs, on, false))
-            System.out.println("OK: invoke without jmx.invoke.getters");
-        System.setProperty("jmx.invoke.getters", "true");
-        if (test(mbs, on, true))
-            System.out.println("OK: invoke with jmx.invoke.getters");
+            System.out.println("OK");
         if (failure == null)
             System.out.println("TEST PASSED");
         else
@@ -117,7 +114,7 @@ private static boolean test(MBeanServer mbs, ObjectName on,
                 System.out.println("isTrue got expected exception: " + e);
         }
 
-        // Following cases should fail whether or not jmx.invoke.getters is set
+        // Following cases should fail
         final Object[][] badInvokes = {
             {"isWhatsit", null, null},
             {"getWhatsit", new Object[] {5}, new String[] {"int"}},