Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: openjdk/jdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 23d6f747
Choose a base ref
...
head repository: openjdk/jdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ebf6b1da
Choose a head ref
  • 17 commits
  • 2 files changed
  • 1 contributor

Commits on Dec 7, 2024

  1. 8331467: Fix JDK-8331467 ImageReaderFactory can cause a ClassNotFound…

    …Exception if the default FileSystemProvider is not the system-default provider
    liyazzi committed Dec 7, 2024

    Unverified

    This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    Copy the full SHA
    8eecd6a View commit details
  2. delete extraneous whitespace

    liyazzi committed Dec 7, 2024

    Unverified

    This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    Copy the full SHA
    6261a50 View commit details
  3. Update CustomFileSystemProviderTest.java

    whitespace errors
    liyazzi authored Dec 7, 2024

    Unverified

    This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    Copy the full SHA
    1552035 View commit details
  4. turn CRLF to CR

    liyazzi committed Dec 7, 2024

    Unverified

    This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    Copy the full SHA
    abc6720 View commit details
  5. turn CRLF to CR

    liyazzi committed Dec 7, 2024
    Copy the full SHA
    a739a46 View commit details
  6. delete foo

    liyazzi committed Dec 7, 2024
    Copy the full SHA
    130df7b View commit details
  7. use LF

    liyazzi committed Dec 7, 2024
    Copy the full SHA
    9022232 View commit details
  8. deal with trailing whitespace

    liyazzi committed Dec 7, 2024
    Copy the full SHA
    7830109 View commit details
  9. add test.jdk value log

    liyazzi committed Dec 7, 2024
    Copy the full SHA
    c8d046e View commit details

Commits on Dec 9, 2024

  1. remove the '\s' and trailing whitespace

    liyazzi committed Dec 9, 2024
    Copy the full SHA
    c7590d2 View commit details
  2. empty commit

    liyazzi committed Dec 9, 2024
    Copy the full SHA
    042c9fe View commit details
  3. add '\s' to avoid trailing whiteSpace

    liyazzi committed Dec 9, 2024
    Copy the full SHA
    c29c6f0 View commit details

Commits on Dec 10, 2024

  1. add test case in test/jdk/java/nio/file/spi/SetDefaultProvider.java a…

    …s the test of this issue
    liyazzi committed Dec 10, 2024
    Copy the full SHA
    e3c336c View commit details

Commits on Dec 14, 2024

  1. Merge branch 'openjdk:master' into 8331467

    liyazzi authored Dec 14, 2024
    Copy the full SHA
    c97dba9 View commit details

Commits on Dec 19, 2024

  1. revert the SetDefaultProvider

    liyazzi committed Dec 19, 2024
    Copy the full SHA
    ab55849 View commit details
  2. Copy the full SHA
    f79261d View commit details
  3. Enable the 'testFspInRuntimeImage' test in SetDefaultProvider

    liyazzi committed Dec 19, 2024
    Copy the full SHA
    ebf6b1d View commit details
Showing with 20 additions and 5 deletions.
  1. +19 −3 src/java.base/share/classes/jdk/internal/jimage/ImageReaderFactory.java
  2. +1 −2 test/jdk/java/nio/file/spi/SetDefaultProvider.java
Original file line number Diff line number Diff line change
@@ -27,8 +27,9 @@

import java.io.IOException;
import java.io.UncheckedIOException;
import java.nio.file.FileSystem;
import java.nio.file.FileSystems;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.concurrent.ConcurrentHashMap;
import java.util.Map;
import java.util.Objects;
@@ -47,8 +48,23 @@ public class ImageReaderFactory {
private ImageReaderFactory() {}

private static final String JAVA_HOME = System.getProperty("java.home");
private static final Path BOOT_MODULES_JIMAGE =
Paths.get(JAVA_HOME, "lib", "modules");
private static final Path BOOT_MODULES_JIMAGE;

static {
FileSystem fs;
if (ImageReaderFactory.class.getClassLoader() == null) {
try {
fs = (FileSystem) Class.forName("sun.nio.fs.DefaultFileSystemProvider")
.getMethod("theFileSystem")
.invoke(null);
} catch (Exception e) {
throw new ExceptionInInitializerError(e);
}
} else {
fs = FileSystems.getDefault();
}
BOOT_MODULES_JIMAGE = fs.getPath(JAVA_HOME, "lib", "modules");
}

private static final Map<Path, ImageReader> readers = new ConcurrentHashMap<>();

3 changes: 1 addition & 2 deletions test/jdk/java/nio/file/spi/SetDefaultProvider.java
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@

/*
* @test
* @bug 4313887 7006126 8142968 8178380 8183320 8210112 8266345 8263940
* @bug 4313887 7006126 8142968 8178380 8183320 8210112 8266345 8263940 8331467
* @modules jdk.jartool jdk.jlink
* @library /test/lib
* @build testfsp/* testapp/*
@@ -124,7 +124,6 @@ void testFspOnModulePath2() throws Exception {
/**
* Test file system provider linked into run-time image.
*/
@Disabled
@Test
void testFspInRuntimeImage() throws Exception {
String image = "image";