Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292880: Improve debuggee logging for com/sun/jdi/ClassUnloadEventTest.java #10004

Closed
wants to merge 2 commits into from

Conversation

plummercj
Copy link
Contributor

@plummercj plummercj commented Aug 24, 2022

In order to help debug JDK-8292879 failures, turn on class unload tracing in the debuggee and also have the debugger dump all the debuggee output. See the CR for example output.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292880: Improve debuggee logging for com/sun/jdi/ClassUnloadEventTest.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10004/head:pull/10004
$ git checkout pull/10004

Update a local copy of the PR:
$ git checkout pull/10004
$ git pull https://git.openjdk.org/jdk pull/10004/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10004

View PR using the GUI difftool:
$ git pr show -t 10004

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10004.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 24, 2022

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8292880 8292880: Improve debuggee logging for com/sun/jdi/ClassUnloadEventTest.java Aug 24, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 24, 2022
@openjdk
Copy link

openjdk bot commented Aug 24, 2022

@plummercj The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Aug 24, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 24, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 24, 2022

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292880: Improve debuggee logging for com/sun/jdi/ClassUnloadEventTest.java

Reviewed-by: amenkov, kevinw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 93 new commits pushed to the master branch:

  • 5a20bc4: 8292715: Cleanup Problemlist
  • 7b81a9c: 8289764: gc/lock tests failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects"
  • 76ee549: 8292329: Enable CDS shared heap for zero builds
  • 14623c6: 8292739: Invalid legacy entries may be returned by Provider.getServices() call
  • 568be58: 8290469: Add new positioning options to PassFailJFrame test framework
  • 69448f9: 8292679: Simplify thread creation in gtest and port 2 tests to new way
  • 3c2289d: 8215916: The failure reason of an optional JAAS LoginModule is not logged
  • 71ab5c9: 8292816: GPL Classpath exception missing from assemblyprefix.h
  • c062397: 8292713: Unsafe.allocateInstance should be intrinsified without UseUnalignedAccesses
  • a45a4b9: 8292194: G1 nmethod entry barrier disarm value wraps around too early
  • ... and 83 more: https://git.openjdk.org/jdk/compare/0d96546ab93600f17877e5db2770e4125916bcda...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 24, 2022
@plummercj
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 25, 2022

Going to push as commit 3e18773.
Since your change was applied there have been 107 commits pushed to the master branch:

  • 909e1ed: 8292919: Build failure due to UseJVMCICompiler was not declared when C2 is disabled after JDK-8292691
  • 55f5a83: 8282410: Remove SA ProcDebugger support
  • d83faea: 8292250: Create test for co-located JDI MethodEntry, Step, and Breakpoint events
  • e353b57: 8292890: Remove PrintTouchedMethodsAtExit and LogTouchedMethods
  • 95a33fe: 8292314: Cleanup legacy address handling
  • 5d799d8: 8292304: [REDO] JDK-8289208 Test DrawRotatedStringUsingRotatedFont.java occasionally crashes on MacOS
  • 4f50316: 8292680: Convert Dictionary to ConcurrentHashTable
  • 2fe0ce0: 8292203: AArch64: Represent Registers as values
  • 251bff6: 8292877: java/util/concurrent/atomic/Serial.java uses {Double,Long}Accumulator incorrectly
  • f57d342: 8292867: RISC-V: Simplify weak CAS return value handling
  • ... and 97 more: https://git.openjdk.org/jdk/compare/0d96546ab93600f17877e5db2770e4125916bcda...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 25, 2022
@openjdk openjdk bot closed this Aug 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 25, 2022
@openjdk
Copy link

openjdk bot commented Aug 25, 2022

@plummercj Pushed as commit 3e18773.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@plummercj plummercj deleted the 8292880_unload_output branch October 11, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
3 participants