Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292972: Initialize fields if CodeBlobIterator shortcuts without heaps #10041

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Aug 26, 2022

SonarCloud reports that CodeBlobIterator::_code_blob is not initialized on shortcut path:

  CodeBlobIterator(LivenessFilter filter, T* nm = NULL)
    : _only_not_unloading(filter == only_not_unloading)
  {
    if (Filter::heaps() == NULL) {
      return; <---- here
    }

It seems that we don't have an actual bug here, as iterator shortcuts on _heap == _end, but it would be cleaner to avoid garbage anyway.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292972: Initialize fields if CodeBlobIterator shortcuts without heaps

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10041/head:pull/10041
$ git checkout pull/10041

Update a local copy of the PR:
$ git checkout pull/10041
$ git pull https://git.openjdk.org/jdk pull/10041/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10041

View PR using the GUI difftool:
$ git pr show -t 10041

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10041.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 26, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 26, 2022
@openjdk
Copy link

openjdk bot commented Aug 26, 2022

@shipilev The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Aug 26, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 26, 2022

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@openjdk
Copy link

openjdk bot commented Aug 26, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292972: Initialize fields if CodeBlobIterator shortcuts without heaps

Reviewed-by: kvn, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

  • a476ec5: 8292983: ModuleReferenceImpl.computeHash should record algorithm for cache checks
  • 99cab6a: 8292911: Add a note about jtreg failure handlers in the testing doc
  • f6b6360: 8289949: Improve test coverage for XPath: operators
  • b0e0b87: 8292917: [JVMCI] Extend InstalledCode API to make an nmethod non entrant.
  • 1500d3d: 8292994: ProblemList vmTestbase/gc/lock/jni/jnilock001/TestDescription.java
  • 4e457ac: 8291760: PipelineLeaksFD.java still fails: More or fewer pipes than expected
  • 774edeb: 8271615: vmTestbase/vm/jit/LongTransitions/ test fail due to locale mismatch
  • 9a0d1e7: 8292541: [Metrics] Reported memory limit may exceed physical machine memory
  • c74b6d4: 8292562: (fc) Use copy_file_range in FileChannel::transferTo on Linux
  • 3844685: 8292697: ZGC: Hangs when almost out of metaspace memory
  • ... and 14 more: https://git.openjdk.org/jdk/compare/251bff6beeafcd98824dab60e9831c0175fe0689...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 26, 2022
Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@shipilev
Copy link
Member Author

Thanks!

/integrate

@openjdk
Copy link

openjdk bot commented Aug 29, 2022

Going to push as commit 512fee1.
Since your change was applied there have been 24 commits pushed to the master branch:

  • a476ec5: 8292983: ModuleReferenceImpl.computeHash should record algorithm for cache checks
  • 99cab6a: 8292911: Add a note about jtreg failure handlers in the testing doc
  • f6b6360: 8289949: Improve test coverage for XPath: operators
  • b0e0b87: 8292917: [JVMCI] Extend InstalledCode API to make an nmethod non entrant.
  • 1500d3d: 8292994: ProblemList vmTestbase/gc/lock/jni/jnilock001/TestDescription.java
  • 4e457ac: 8291760: PipelineLeaksFD.java still fails: More or fewer pipes than expected
  • 774edeb: 8271615: vmTestbase/vm/jit/LongTransitions/ test fail due to locale mismatch
  • 9a0d1e7: 8292541: [Metrics] Reported memory limit may exceed physical machine memory
  • c74b6d4: 8292562: (fc) Use copy_file_range in FileChannel::transferTo on Linux
  • 3844685: 8292697: ZGC: Hangs when almost out of metaspace memory
  • ... and 14 more: https://git.openjdk.org/jdk/compare/251bff6beeafcd98824dab60e9831c0175fe0689...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 29, 2022
@openjdk openjdk bot closed this Aug 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 29, 2022
@openjdk
Copy link

openjdk bot commented Aug 29, 2022

@shipilev Pushed as commit 512fee1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8292972-codeblob-odd branch September 5, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants