8293050: RISC-V: Remove redundant non-null assertions about macro-assembler

[RealFYang]

There are some non-null assertions about macro-assembler in riscv-specific code. Most of them are there to make some internal code-check tools happy. We should remove those redundant assertions to make the code clean.

Tested with tier1 hotspot on linux-riscv64 unmatched.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8293050: RISC-V: Remove redundant non-null assertions about macro-assembler

Reviewers

• Feilong Jiang (@feilongjiang - Author) ⚠️ Review applies to 126780fb
• Yadong Wang (@yadongw - Author) ⚠️ Review applies to 126780fb
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10079/head:pull/10079
$ git checkout pull/10079

Update a local copy of the PR:
$ git checkout pull/10079
$ git pull https://git.openjdk.org/jdk pull/10079/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10079

View PR using the GUI difftool:
$ git pr show -t 10079

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10079.diff

[bridgekeeper]

👋 Welcome back fyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RealFYang The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (3547131e)
• 00: Full (126780fb)

[feilongjiang]

Nice clean up! LGTM.

[RealFYang]

@shipilev : Want to take a look? Thanks.

[yadongw]

lgtm(not a reviewer)

[shipilev]

Looks okay, but I wonder if we want to do the fence change separately.

[openjdk]

@RealFYang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293050: RISC-V: Remove redundant non-null assertions about macro-assembler

Reviewed-by: fjiang, yadongwang, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• 4c90e87: 8290781: Segfault at PhaseIdealLoop::clone_loop_handle_data_uses
• 9e3176b: 8293035: Cleanup MacroAssembler::movoop code patching logic aarch64 riscv
• c42478b: 8293109: Remove unused methods in Compiler
• d2eed07: 8293020: jmod should not be treated as "small" tool for large modules
• 923c952: 8293098: GHA: Harmonize GCC version handling for host and cross builds
• 38377d5: 8291649: multiple tests failing with -Xcomp after JDK-8290034
• 2d7792c: 8293065: Zero build failure on AArch64 and RISCV64 after JDK-8293007
• c3380c0: 8292995: improve the SA page cache
• 1cf245d: 8292590: Product JVM crashes with FLAG_SET_XXX on non-product Flag
• 6335150: 6205692: (spec) javax.crypto.MacSpi.engineUpdate(ByteBuffer input): NPE should be specified
• ... and 10 more: https://git.openjdk.org/jdk/compare/b3450e930e52f03ffc3891de7672625ac45b13d0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealFYang]

Thanks all the review. I think it's safe to integrate then.
/integrate

[openjdk]

Going to push as commit 38e6706.
Since your change was applied there have been 20 commits pushed to the master branch:

• 4c90e87: 8290781: Segfault at PhaseIdealLoop::clone_loop_handle_data_uses
• 9e3176b: 8293035: Cleanup MacroAssembler::movoop code patching logic aarch64 riscv
• c42478b: 8293109: Remove unused methods in Compiler
• d2eed07: 8293020: jmod should not be treated as "small" tool for large modules
• 923c952: 8293098: GHA: Harmonize GCC version handling for host and cross builds
• 38377d5: 8291649: multiple tests failing with -Xcomp after JDK-8290034
• 2d7792c: 8293065: Zero build failure on AArch64 and RISCV64 after JDK-8293007
• c3380c0: 8292995: improve the SA page cache
• 1cf245d: 8292590: Product JVM crashes with FLAG_SET_XXX on non-product Flag
• 6335150: 6205692: (spec) javax.crypto.MacSpi.engineUpdate(ByteBuffer input): NPE should be specified
• ... and 10 more: https://git.openjdk.org/jdk/compare/b3450e930e52f03ffc3891de7672625ac45b13d0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealFYang Pushed as commit 38e6706.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.