8287912: GTK L&F : Background of tree icons are red #10112

kumarabhi006 · 2022-09-01T06:27:17Z

The background of tree icons are not red in GTK LAF when setOpaque is set to false for tree component.
It has been observed that while painting tree cell background in GTK LAF, a rectangular area is also painted with background color (white).

Proposed solution is to check the opacity of tree component before drawing tree cell background. If the opacity is set to "false" then the background shouldn't be painted.

An automated test case has been added and checked in CI, link is added in JBS.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8287912: GTK L&F : Background of tree icons are red

Reviewers

Prasanta Sadhukhan (@prsadhuk - Reviewer)
Jayathirth D V (@jayathirthrao - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10112/head:pull/10112
$ git checkout pull/10112

Update a local copy of the PR:
$ git checkout pull/10112
$ git pull https://git.openjdk.org/jdk pull/10112/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10112

View PR using the GUI difftool:
$ git pr show -t 10112

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10112.diff

bridgekeeper · 2022-09-01T06:27:48Z

👋 Welcome back kumarabhi006! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-09-01T06:32:21Z

@kumarabhi006 The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-09-01T16:12:47Z

Webrevs

prsadhuk · 2022-09-01T16:54:23Z

test/jdk/javax/swing/JTree/TestTreeBackgroundColor.java

@@ -0,0 +1,112 @@
+


remove this empty line

prsadhuk · 2022-09-01T16:56:00Z

test/jdk/javax/swing/JTree/TestTreeBackgroundColor.java

+
+                    if (c.equals(Color.RED)) {
+                        passed = true;
+                    }


better to check at midpoint tree.width/2, tree.height/2 and also break if it's RED, no need to check all pixels.

Another possible solution that I used in a previous test was a midpoint as suggested, but also one pixel near each edge. This eliminates the chance of the red still existing but not being detected at the midpoint because the red is at a different location.

The test check has been changed to compare the pixels of entire width keeping the height constant to half of tree height. Now it will check pixel color and if it is not red , the test will fail.

For me, test is not failing without the fix.
Also, if you test entire width and fail if it is not red, it might encounter black pixel of text font too and might fail, so I think it's better to check width/2 to width -1 and not entire width.

Also, it's might be better to write the image in case of failure so that it gives an idea why it failed.

For me, test is not failing without the fix. Also, if you test entire width and fail if it is not red, it might encounter black pixel of text font too and might fail, so I think it's better to check width/2 to width -1 and not entire width.

Test was not failing without the fix because the second argument of getRGB method is height/2, and for that pixel value the returned color is red.
Changing the argument from height/2 to height/4 will fail the test without the fix otherwise it will pass the test.

Also writing the image in case of failure.

This looks ok .Please remove the empty 1st line in the test.

jayathirthrao · 2022-09-02T06:11:47Z

test/jdk/javax/swing/JTree/TestTreeBackgroundColor.java

+                    }
+                }
+            }
+            if (!passed) {


This test will pass even in the case of last pixel check is RED. We should check for pixel data and whenever it is not RED we should bail out.

Also if test fails it will leave TreeBackgroundColorTestFail.png, we should use temporary file and delete it on exit.

I have removed the writing of test image in case of fail operation and test condition changed to check if pixel color is not red then test will fail.

openjdk · 2022-09-06T07:27:50Z

@kumarabhi006 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287912: GTK L&F : Background of tree icons are red

Reviewed-by: psadhukhan, jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 751 new commits pushed to the master branch:

272745b: 8293340: Remove unused _code in {Zero,Template}InterpreterGenerator
26f2a97: 8290561: Coalesce incubator-module warnings for single-file source-code programs
8e22f2b: 8293361: GHA: dump config.log in case of configure failure
b17758a: 8247283: Enable the new conformant preprocessor option in Visual Studio
1bed23a: 8293353: [BACKOUT] G1: Remove redundant is-marking-active checks in C1 barrier
4955835: 8282434: Leading combining diacritic character in string renders incorrectly
ef20ffe: 8293159: Use try-with-resources in X11FontManager.registerFontDir
056ed48: 8293180: JQuery UI license file not updated
dbb2c4b: 8288897: Clean up node dump code
9833c02: 8292946: GC lock/jni/jnilock001 test failed "assert(gch->gc_cause() == GCCause::_scavenge_alot || !gch->incremental_collection_failed()) failed: Twice in a row"
... and 741 more: https://git.openjdk.org/jdk/compare/ac6be165196457a26d837760b5f5030fe010d633...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prsadhuk, @jayathirthrao) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

kumarabhi006 · 2022-09-06T10:35:06Z

/integrate

openjdk · 2022-09-06T10:36:59Z

@kumarabhi006
Your change (at version 930a7fb) is now ready to be sponsored by a Committer.

jayathirthrao · 2022-09-06T10:52:39Z

/sponsor

openjdk · 2022-09-06T10:55:15Z

Going to push as commit a92c1ff.
Since your change was applied there have been 751 commits pushed to the master branch:

272745b: 8293340: Remove unused _code in {Zero,Template}InterpreterGenerator
26f2a97: 8290561: Coalesce incubator-module warnings for single-file source-code programs
8e22f2b: 8293361: GHA: dump config.log in case of configure failure
b17758a: 8247283: Enable the new conformant preprocessor option in Visual Studio
1bed23a: 8293353: [BACKOUT] G1: Remove redundant is-marking-active checks in C1 barrier
4955835: 8282434: Leading combining diacritic character in string renders incorrectly
ef20ffe: 8293159: Use try-with-resources in X11FontManager.registerFontDir
056ed48: 8293180: JQuery UI license file not updated
dbb2c4b: 8288897: Clean up node dump code
9833c02: 8292946: GC lock/jni/jnilock001 test failed "assert(gch->gc_cause() == GCCause::_scavenge_alot || !gch->incremental_collection_failed()) failed: Twice in a row"
... and 741 more: https://git.openjdk.org/jdk/compare/ac6be165196457a26d837760b5f5030fe010d633...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-09-06T10:55:37Z

@jayathirthrao @kumarabhi006 Pushed as commit a92c1ff.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Fix for tree icon background in GTK LAF

c7dba8b

openjdk bot added the client client-libs-dev@openjdk.org label Sep 1, 2022

Whitespace error fixed

17d6100

openjdk bot added the rfr Pull request is ready for review label Sep 1, 2022

prsadhuk reviewed Sep 1, 2022

View reviewed changes

jayathirthrao reviewed Sep 2, 2022

View reviewed changes

kumarabhi006 added 3 commits September 2, 2022 12:32

Review Comments fix

fb3db43

Review comments fix

f3fd0e7

Empty 1st line removed in test

930a7fb

prsadhuk approved these changes Sep 6, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 6, 2022

jayathirthrao approved these changes Sep 6, 2022

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 6, 2022

openjdk bot added the integrated Pull request has been integrated label Sep 6, 2022

openjdk bot closed this Sep 6, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8287912: GTK L&F : Background of tree icons are red #10112

8287912: GTK L&F : Background of tree icons are red #10112

kumarabhi006 commented Sep 1, 2022 •

edited by openjdk bot

bridgekeeper bot commented Sep 1, 2022

openjdk bot commented Sep 1, 2022

mlbridge bot commented Sep 1, 2022 •

edited

prsadhuk Sep 1, 2022

prsadhuk Sep 1, 2022

DamonGuy Sep 2, 2022

kumarabhi006 Sep 2, 2022

prsadhuk Sep 5, 2022

prsadhuk Sep 5, 2022

kumarabhi006 Sep 5, 2022

prsadhuk Sep 6, 2022

jayathirthrao Sep 2, 2022

kumarabhi006 Sep 2, 2022

openjdk bot commented Sep 6, 2022 •

edited

kumarabhi006 commented Sep 6, 2022

openjdk bot commented Sep 6, 2022

jayathirthrao commented Sep 6, 2022

openjdk bot commented Sep 6, 2022

openjdk bot commented Sep 6, 2022

8287912: GTK L&F : Background of tree icons are red #10112

8287912: GTK L&F : Background of tree icons are red #10112

Conversation

kumarabhi006 commented Sep 1, 2022 • edited by openjdk bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Sep 1, 2022

openjdk bot commented Sep 1, 2022

mlbridge bot commented Sep 1, 2022 • edited

Webrevs

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openjdk bot commented Sep 6, 2022 • edited

kumarabhi006 commented Sep 6, 2022

openjdk bot commented Sep 6, 2022

jayathirthrao commented Sep 6, 2022

openjdk bot commented Sep 6, 2022

openjdk bot commented Sep 6, 2022

kumarabhi006 commented Sep 1, 2022 •

edited by openjdk bot

mlbridge bot commented Sep 1, 2022 •

edited

openjdk bot commented Sep 6, 2022 •

edited