8234315: GTK LAF does not gray out disabled JMenu

[kumarabhi006]

Disabled JMenu foreground color was not grayed out in GTK LAF for version 3. The issue didn't occur in GTK-2.
After analysis it has been found that the JMenu widget type was changed to JMenuBar and the color value returned for the foreground color in disabled state was close to black color (RGB 0,0,0) for menubar which is not differentiable from enabled state foreground color.

As a fix for this problem, if the menubar is in disabled state then the widget is changed to JMenu and color value returned for disabled menu is gray color.

An automated test case has been added and checked in CI, link is added in JBS.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8234315: GTK LAF does not gray out disabled JMenu

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)
• Prasanta Sadhukhan (@prsadhuk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10176/head:pull/10176
$ git checkout pull/10176

Update a local copy of the PR:
$ git checkout pull/10176
$ git pull https://git.openjdk.org/jdk pull/10176/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10176

View PR using the GUI difftool:
$ git pr show -t 10176

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10176.diff

[bridgekeeper]

👋 Welcome back kumarabhi006! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kumarabhi006 The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a602071c)

[mrserb]

Does the new color looks the same as in the native applications?

[kumarabhi006]

Does the new color looks the same as in the native applications?

I think it is same as in native application. Attached a screenshot of test application and text editor (gedit) in ubuntu.

[mrserb]

Looks fine, please double how it will work if the dark theme is set.

[openjdk]

@kumarabhi006 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8234315: GTK LAF does not gray out disabled JMenu

Reviewed-by: serb, psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 797 new commits pushed to the master branch:

• 812d805: 6447816: Provider filtering (getProviders) is not working with OR'd conditions
• 43e191d: 8293524: RISC-V: Use macro-assembler functions as appropriate
• 14eb5ad: 8291753: Add JFR event for GC CPU Time
• 30d4145: 8293230: x86_64: Move AES and GHASH stub definitions into separate source files
• 4c5501c: 8293548: ProblemList sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64
• 46e6e41: 8293051: Further refactor javac after removal of -source/-target/--release 7
• c0ee30a: 8293348: A false cyclic inheritance error reported
• 85ec1f8: 8293492: ShenandoahControlThread missing from hs-err log and thread dump
• 6bd2794: 8293304: Replace some usages of INTPTR_FORMAT with PTR_FORMAT
• 98da03a: 8293432: Use diamond operator in java.management
• ... and 787 more: https://git.openjdk.org/jdk/compare/ac6be165196457a26d837760b5f5030fe010d633...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb, @prsadhuk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[kumarabhi006]

Looks fine, please double how it will work if the dark theme is set.

In case of dark theme set, foreground color is grayed out.

[kumarabhi006]

/integrate

[openjdk]

@kumarabhi006
Your change (at version a602071) is now ready to be sponsored by a Committer.

[prsadhuk]

/sponsor

[openjdk]

Going to push as commit 9d6b028.
Since your change was applied there have been 797 commits pushed to the master branch:

• 812d805: 6447816: Provider filtering (getProviders) is not working with OR'd conditions
• 43e191d: 8293524: RISC-V: Use macro-assembler functions as appropriate
• 14eb5ad: 8291753: Add JFR event for GC CPU Time
• 30d4145: 8293230: x86_64: Move AES and GHASH stub definitions into separate source files
• 4c5501c: 8293548: ProblemList sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64
• 46e6e41: 8293051: Further refactor javac after removal of -source/-target/--release 7
• c0ee30a: 8293348: A false cyclic inheritance error reported
• 85ec1f8: 8293492: ShenandoahControlThread missing from hs-err log and thread dump
• 6bd2794: 8293304: Replace some usages of INTPTR_FORMAT with PTR_FORMAT
• 98da03a: 8293432: Use diamond operator in java.management
• ... and 787 more: https://git.openjdk.org/jdk/compare/ac6be165196457a26d837760b5f5030fe010d633...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prsadhuk @kumarabhi006 Pushed as commit 9d6b028.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.