8293333: Broken links in JDI specification

[sspitsyn]

The JDI files com/sun/jdi/ClassLoaderReference.java and com/sun/jdi/VirtualMachine.java have incorrect links to the JVM TI spec with the extra folder name jvmti.

The fix is to get rid unneeded part from the links:

--- a/src/jdk.jdi/share/classes/com/sun/jdi/ClassLoaderReference.java
+++ b/src/jdk.jdi/share/classes/com/sun/jdi/ClassLoaderReference.java
@@ -93,7 +93,7 @@ public interface ClassLoaderReference extends ObjectReference {
      * classes which this class loader can find by name. The list
      * has length 0 if no classes are visible to this classloader.
      *
-     * @see <a href="{@docRoot}/../specs/jvmti/jvmti.html#GetClassLoaderClasses">
+     * @see <a href="{@docRoot}/../specs/jvmti.html#GetClassLoaderClasses">
      *     JVM TI GetClassLoaderClasses</a>
      */
     List<ReferenceType> visibleClasses();
diff --git a/src/jdk.jdi/share/classes/com/sun/jdi/VirtualMachine.java b/src/jdk.jdi/share/classes/com/sun/jdi/VirtualMachine.java
index 12cdd566989..64c91c8d1bb 100644
--- a/src/jdk.jdi/share/classes/com/sun/jdi/VirtualMachine.java
+++ b/src/jdk.jdi/share/classes/com/sun/jdi/VirtualMachine.java
@@ -144,7 +144,7 @@ public interface VirtualMachine extends Mirror {
      *
      * @return a list of {@link ReferenceType} objects, each mirroring
      * a loaded type in the target VM.
-     * @see <a href="{@docRoot}/../specs/jvmti/jvmti.html#GetLoadedClasses">
+     * @see <a href="{@docRoot}/../specs/jvmti.html#GetLoadedClasses">
      * JVM TI GetLoadedClasses</a> regarding how class and interface creation can be triggered
      */
     List<ReferenceType> allClasses();

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8293333: Broken links in JDI specification

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)
• Chris Plummer (@plummercj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10191/head:pull/10191
$ git checkout pull/10191

Update a local copy of the PR:
$ git checkout pull/10191
$ git pull https://git.openjdk.org/jdk pull/10191/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10191

View PR using the GUI difftool:
$ git pr show -t 10191

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10191.diff

[bridgekeeper]

👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sspitsyn The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (aba76570)

[openjdk]

@sspitsyn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293333: Broken links in JDI specification

Reviewed-by: alanb, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 2259e42: 8293197: Avoid double racy reads from non-volatile fields in SharedSecrets

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sspitsyn]

Alan and Chris, thank you for quick review!

[sspitsyn]

/integrate

[openjdk]

Going to push as commit 4f9065d.
Since your change was applied there has been 1 commit pushed to the master branch:

• 2259e42: 8293197: Avoid double racy reads from non-volatile fields in SharedSecrets

Your commit was automatically rebased without conflicts.

[openjdk]

@sspitsyn Pushed as commit 4f9065d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.