Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293512: ProblemList serviceability/tmtools/jstat/GcNewTest.java in -Xcomp mode #10209

Closed
wants to merge 4 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Sep 7, 2022

Trivial fixes to ProblemList 4 tests that fail in the upper Tiers:

JDK-8293512 ProblemList serviceability/tmtools/jstat/GcNewTest.java in -Xcomp mode

JDK-8293516 ProblemList gc/cslocker/TestCSLocker.java in -Xcomp mode

JDK-8293517 ProblemList sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64

JDK-8293518 ProblemList sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.java


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8293512: ProblemList serviceability/tmtools/jstat/GcNewTest.java in -Xcomp mode
  • JDK-8293516: ProblemList gc/cslocker/TestCSLocker.java in -Xcomp mode
  • JDK-8293517: ProblemList sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64
  • JDK-8293518: ProblemList sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10209/head:pull/10209
$ git checkout pull/10209

Update a local copy of the PR:
$ git checkout pull/10209
$ git pull https://git.openjdk.org/jdk pull/10209/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10209

View PR using the GUI difftool:
$ git pr show -t 10209

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10209.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 7, 2022

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add hotspot-gc
/label add serviceability

@dcubed-ojdk
Copy link
Member Author

/issue JDK-8293512
/issue JDK-8293516
/issue JDK-8293517
/issue JDK-8293518

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Sep 7, 2022
@openjdk
Copy link

openjdk bot commented Sep 7, 2022

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review September 7, 2022 21:55
@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Sep 7, 2022
@openjdk
Copy link

openjdk bot commented Sep 7, 2022

@dcubed-ojdk
The hotspot-gc label was successfully added.

@openjdk openjdk bot added rfr Pull request is ready for review serviceability serviceability-dev@openjdk.org labels Sep 7, 2022
@openjdk
Copy link

openjdk bot commented Sep 7, 2022

@dcubed-ojdk
The serviceability label was successfully added.

@openjdk
Copy link

openjdk bot commented Sep 7, 2022

@dcubed-ojdk This issue is referenced in the PR title - it will now be updated.

@openjdk
Copy link

openjdk bot commented Sep 7, 2022

@dcubed-ojdk
Adding additional issue to issue list: 8293516: ProblemList gc/cslocker/TestCSLocker.java in -Xcomp mode.

@openjdk
Copy link

openjdk bot commented Sep 7, 2022

@dcubed-ojdk
Adding additional issue to issue list: 8293517: ProblemList sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64.

@openjdk
Copy link

openjdk bot commented Sep 7, 2022

@dcubed-ojdk
Adding additional issue to issue list: 8293518: ProblemList sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.java.

@openjdk
Copy link

openjdk bot commented Sep 7, 2022

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293512: ProblemList serviceability/tmtools/jstat/GcNewTest.java in -Xcomp mode
8293516: ProblemList gc/cslocker/TestCSLocker.java in -Xcomp mode
8293517: ProblemList sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64
8293518: ProblemList sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.java

Reviewed-by: bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 51de765: 8283010: serviceability/sa/ClhsdbThread.java failed with "'Base of Stack:' missing from stdout/stderr "
  • 8a48965: 8293514: ProblemList gc/metaspace/TestMetaspacePerfCounters.java#Epsilon-64 on all platforms

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 7, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 7, 2022

Webrevs

@dcubed-ojdk
Copy link
Member Author

@bplb - Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Sep 7, 2022

Going to push as commit 2d13f53.
Since your change was applied there have been 3 commits pushed to the master branch:

  • f84386c: 8293182: Improve testing of CDS archive heap
  • 51de765: 8283010: serviceability/sa/ClhsdbThread.java failed with "'Base of Stack:' missing from stdout/stderr "
  • 8a48965: 8293514: ProblemList gc/metaspace/TestMetaspacePerfCounters.java#Epsilon-64 on all platforms

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 7, 2022
@openjdk openjdk bot closed this Sep 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 7, 2022
@openjdk
Copy link

openjdk bot commented Sep 7, 2022

@dcubed-ojdk Pushed as commit 2d13f53.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8293512 branch September 8, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
2 participants