8293991: java/lang/Float/Binary16ConversionNaN.java fails on silent NaN conversions

[shipilev]

Reliably reproduces on x86-32 with FPU:

$ CONF=linux-x86-server-fastdebug make test TEST=java/lang/Float/Binary16ConversionNaN.java TEST_VM_OPTS="-XX:UseAVX=0 -XX:UseSSE=0"
...
Roundtrip failure on NaN value 7de2 got back 7fe2
Roundtrip failure on NaN value fde2 got back ffe2

Since there are many NaN values in FP16 -- basically any non-zero significand works, we should probably just relax the test a bit.

Attn @jddarcy ;)

Additional testing:

• Linux x86_32 fastdebug, -XX:UseAVX=0 -XX:UseSSE=0, affected test now passes
• Linux x86_32 fastdebug, -XX:UseAVX=0 -XX:UseSSE=1, affected test still passes
• Linux x86_64 fastdebug, affected test still passes

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8293991: java/lang/Float/Binary16ConversionNaN.java fails on silent NaN conversions

Reviewers

• Joe Darcy (@jddarcy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10333/head:pull/10333
$ git checkout pull/10333

Update a local copy of the PR:
$ git checkout pull/10333
$ git pull https://git.openjdk.org/jdk pull/10333/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10333

View PR using the GUI difftool:
$ git pr show -t 10333

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10333.diff

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (d8019dcc)
• 00: Full (6d101550)

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293991: java/lang/Float/Binary16ConversionNaN.java fails on silent NaN conversions

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• df53fa7: 8292328: AccessibleActionsTest.java test instruction for show popup on JLabel did not specify shift key
• 5285035: 8294075: gtest/AsyncLogGtest crashes with SEGV
• 696287d: 8294037: Using alias template to unify hashtables in AsyncLogWriter
• 48cc156: 8293331: Refactor FileDispatcherImpl into operating system-specific components

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Ok, I am integrating to unbreak this test on x86_32.

/integrate

[openjdk]

Going to push as commit 0b56b82.
Since your change was applied there have been 10 commits pushed to the master branch:

• acd5bcf: 8289610: Degrade Thread.stop
• 05c8cab: 8293532: Use lighter jmod compression levels in build config
• eec992c: 8292602: ZGC: C2 late barrier analysis uses invalid dominator information
• f6d78cd: 8293657: sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 failed with "SSLHandshakeException: Remote host terminated the handshake"
• a4dc035: 8290910: Wrong memory state is picked in SuperWord::co_locate_pack()
• f3ba332: 8294183: AArch64: Wrong macro check in SharedRuntime::generate_deopt_blob
• df53fa7: 8292328: AccessibleActionsTest.java test instruction for show popup on JLabel did not specify shift key
• 5285035: 8294075: gtest/AsyncLogGtest crashes with SEGV
• 696287d: 8294037: Using alias template to unify hashtables in AsyncLogWriter
• 48cc156: 8293331: Refactor FileDispatcherImpl into operating system-specific components

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 0b56b82.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.