8279941: sun/security/pkcs11/Signature/TestDSAKeyLength.java fails when NSS version detection fails

[shipilev]

The test helpers try to identify NSS version by parsing the relevant .so files (!) looking for "Version: ..." string. This fails at least on Ubuntu 22.04, where the NSS does not have any version-identifiable strings. In this case, the test "detects" version as 0.0 and then fails. After brief discussion in the bug, the best fix is to ignore 0.0 as well.

Additional testing:

• Linux x86_64 fastdebug, affected test now skipped on Ubuntu 22.04

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8279941: sun/security/pkcs11/Signature/TestDSAKeyLength.java fails when NSS version detection fails

Reviewers

• Valerie Peng (@valeriepeng - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10346/head:pull/10346
$ git checkout pull/10346

Update a local copy of the PR:
$ git checkout pull/10346
$ git pull https://git.openjdk.org/jdk pull/10346/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10346

View PR using the GUI difftool:
$ git pr show -t 10346

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10346.diff

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f3f8c59f)

[valeriepeng]

Looks good.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279941: sun/security/pkcs11/Signature/TestDSAKeyLength.java fails when NSS version detection fails

Reviewed-by: valeriep

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• 8ff2c26: 8293942: [JVMCI] data section entries must be 4-byte aligned on AArch64
• 6e23b43: 8293502: (fc) FileChannel::transfer methods fail to copy /proc files on Linux
• 1f9ff41: 8292297: Fix up loading of override java.security properties file
• 64b96e5: 8293811: Provide a reason for PassFailJFrame.forceFail
• f91762f: 8293965: Code signing warnings after JDK-8293550
• 8082c24: 8054572: [macosx] JComboBox paints the border incorrectly
• b920d29: 8271328: User is able to choose the color after disabling the color chooser.
• 5725a93: 8293879: Remove unnecessary castings in jdk.hotspot.agent
• ab7f58a: 6286501: JTabbedPane throws NPE from its stateChanged listener in particular case
• d41f69f: 8293849: PrintIdealPhase in compiler directives file is ignored when used with other compile commands
• ... and 2 more: https://git.openjdk.org/jdk/compare/36c9034ff1274f37969550a3f9239f1bb16a0b25...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Looks good.

Thank you! Any other reviews needed, or this one is enough?

[valeriepeng]

One should be enough. Just a trivial change.

[shipilev]

Thanks!

/integrate

[openjdk]

Going to push as commit cddd6de.
Since your change was applied there have been 29 commits pushed to the master branch:

• 21008ca: 8285383: vmTestbase/nsk/jvmti/scenarios/hotswap/HS204/hs204t001/hs204t001.java failed with "exit code: 96"
• 3b438a6: 8294067: [macOS] javax/swing/JComboBox/6559152/bug6559152.java Cannot select an item from popup with the ENTER key.
• caae53f: 8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling
• cb5771d: 8294006: Avoid hardcoding object file suffixes in make
• 5002eaa: 8293828: JFR: jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are not happening
• e3358e7: 8294008: Grapheme implementation of setText() throws IndexOutOfBoundsException
• df8ec09: 8294046: Newly added test test/jdk/javax/swing/JTabbedPane/TestNPEStateChgListener.java fails in macos
• 09af637: 8294012: RISC-V: get/put_native_u8 missing the case when address&7 is 6
• 584de68: 8294058: Early use of lambda introduced in JDK-8285263 cause startup regressions in 20-b02
• bb422f5: 8293595: tstrings::any() is missing an overload
• ... and 19 more: https://git.openjdk.org/jdk/compare/36c9034ff1274f37969550a3f9239f1bb16a0b25...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit cddd6de.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.