8294058: Early use of lambda introduced in JDK-8285263 cause startup regressions in 20-b02

[cl4es]

JDK-8285263 innocuously rewrote an anonymous class in SecureClassLoader.getProtectionDomain to a (capturing) lambda. Since this is called during early bootstrap this shows up as a regression across the board on all our startup and footprint tests.

Restoring the anonymous class drops no. of classes loaded on a Hello World test from 493 to 448 (macosx).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8294058: Early use of lambda introduced in JDK-8285263 cause startup regressions in 20-b02

Reviewers

• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10357/head:pull/10357
$ git checkout pull/10357

Update a local copy of the PR:
$ git checkout pull/10357
$ git pull https://git.openjdk.org/jdk pull/10357/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10357

View PR using the GUI difftool:
$ git pr show -t 10357

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10357.diff

[bridgekeeper]

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@cl4es The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (25aaf7af)

[openjdk]

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294058: Early use of lambda introduced in JDK-8285263 cause startup regressions in 20-b02

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• 1b49606: 8293922: Extend barrier-less Java thread transitions to native transitions
• a07902b: 8293976: Use unsigned integers in Assembler/CodeBuffer::emit_int*
• fe541f0: 8293989: [JVMCI] re-use cleared oop handles
• 0fa7d9e: 8278863: Add method ClassDesc::ofInternalName
• 4020ed5: 8293210: G1: Remove redundant check in G1FreeHumongousRegionClosure
• 8ff2c26: 8293942: [JVMCI] data section entries must be 4-byte aligned on AArch64
• 6e23b43: 8293502: (fc) FileChannel::transfer methods fail to copy /proc files on Linux
• 1f9ff41: 8292297: Fix up loading of override java.security properties file
• 64b96e5: 8293811: Provide a reason for PassFailJFrame.forceFail
• f91762f: 8293965: Code signing warnings after JDK-8293550
• ... and 2 more: https://git.openjdk.org/jdk/compare/5725a93c078dac9775ccef04f3624647a8d38e83...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[cl4es]

Thanks for reviewing, Sean!

/integrate

[openjdk]

Going to push as commit 584de68.
Since your change was applied there have been 15 commits pushed to the master branch:

• bb422f5: 8293595: tstrings::any() is missing an overload
• 0f28cb0: 8294014: Remove redundant UseCompiler conditions
• 84ee1a2: 8293781: RISC-V: Clarify types of calls
• 1b49606: 8293922: Extend barrier-less Java thread transitions to native transitions
• a07902b: 8293976: Use unsigned integers in Assembler/CodeBuffer::emit_int*
• fe541f0: 8293989: [JVMCI] re-use cleared oop handles
• 0fa7d9e: 8278863: Add method ClassDesc::ofInternalName
• 4020ed5: 8293210: G1: Remove redundant check in G1FreeHumongousRegionClosure
• 8ff2c26: 8293942: [JVMCI] data section entries must be 4-byte aligned on AArch64
• 6e23b43: 8293502: (fc) FileChannel::transfer methods fail to copy /proc files on Linux
• ... and 5 more: https://git.openjdk.org/jdk/compare/5725a93c078dac9775ccef04f3624647a8d38e83...master

Your commit was automatically rebased without conflicts.

[openjdk]

@cl4es Pushed as commit 584de68.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.