8294357: (tz) Update Timezone Data to 2022d #10460

satoyoshiki · 2022-09-28T03:40:06Z

Please review this PR. The change include some code changes in ZoneInfoFile.java and TestZoneInfo310.java since tzdata2022d breaks TestZoneInfo310.java.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8294357: (tz) Update Timezone Data to 2022d

Reviewers

Naoto Sato (@naotoj - Reviewer)
Sean Coffey (@coffeys - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10460/head:pull/10460
$ git checkout pull/10460

Update a local copy of the PR:
$ git checkout pull/10460
$ git pull https://git.openjdk.org/jdk pull/10460/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10460

View PR using the GUI difftool:
$ git pr show -t 10460

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10460.diff

bridgekeeper · 2022-09-28T03:41:07Z

👋 Welcome back ysatowse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

satoyoshiki · 2022-09-28T03:41:27Z

/issue JDK-8294357

openjdk · 2022-09-28T03:43:12Z

@satoyoshiki The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

openjdk · 2022-09-28T03:46:16Z

@satoyoshiki The following labels will be automatically applied to this pull request:

core-libs
i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

naotoj

Some minor comments

naotoj · 2022-09-28T16:05:45Z

src/java.base/share/classes/sun/util/calendar/ZoneInfoFile.java

                    // "last", it works for now. From tzdata2020d this hacking
                    // will not work for Asia/Gaza and Asia/Hebron which follow
                    // Palestine DST rules.
-                    if (dom < 0 || dom >= 24 &&
-                                   !(zoneId.equals("Asia/Gaza") ||
-                                     zoneId.equals("Asia/Hebron"))) {
+                    // No need of hacking for Plaestine DST rules from tz2022d


Should this comment be removed, or at least modified to be better explained?

naotoj · 2022-09-28T16:07:16Z

test/jdk/sun/util/calendar/zi/TestZoneInfo310.java

+                zid.equals("Asia/Gaza") ||
+                zid.equals("Asia/Hebron") ||


It'd be helpful to append // uses "Palestine" rule.

mlbridge · 2022-09-30T00:36:53Z

Webrevs

00: Full (a896323d)

naotoj · 2022-09-30T04:17:54Z

test/jdk/java/util/TimeZone/TimeZoneData/displaynames.txt

-Europe/Uzhgorod EET EEST
 Europe/Vienna CET CEST
 Europe/Vilnius EET EEST
 Europe/Warsaw CET CEST
-Europe/Zaporozhye EET EEST


Do we need to remove those newly linked zone ids from testing?

This file is not maintained by hand but generated from java/util/TimeZone/TimeZoneData/tools/share/Makefile.
These two Ukraine zones are integrated to Europe/Kyiv and removed from tzdata/europe, so the entries disappeared in this file.

OK. It's a bit odd that the links are removed for the test because they still exist as zone ids, and should have the same name as Europe/Kyiv.

coffeys

LGTM

openjdk · 2022-09-30T05:43:59Z

@satoyoshiki This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294357: (tz) Update Timezone Data to 2022d

Reviewed-by: naoto, coffeys

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 58 new commits pushed to the master branch:

64da862: 8287597: List all preview features on the javadoc PREVIEW page
b4e1e41: 8293000: Review running times of jshell regression tests
6d83482: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts
6974978: 8294521: Parallel: Remove unused field in UpdateDensePrefixAndCompactionTask
81fda1b: 8294569: Remove CardTable::_last_valid_index
7c60e6d: 8293770: RISC-V: Reuse runtime call trampolines
9dce865: 8294115: JNI local refs exceeds capacity warning in NetworkInterface::getAll
b030c7d: 8225235: Unused field defaultIndex in NetworkInterface
a07975b: 8294519: (fs) java/nio/file/Files/CopyProcFile.java fails intermittenly due to unstable /proc/cpuinfo output
88062ee: 8293969: breakup the long signature in SystemDictionaryShared::is_supported_invokedynamic
... and 48 more: https://git.openjdk.org/jdk/compare/aa48705dddee674baa479f5128cfc3b426d87d2d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj, @coffeys) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

satoyoshiki · 2022-09-30T07:37:01Z

/integrate

openjdk · 2022-09-30T07:38:19Z

@satoyoshiki
Your change (at version a896323) is now ready to be sponsored by a Committer.

naotoj · 2022-09-30T12:42:57Z

/sponsor

openjdk · 2022-09-30T12:45:45Z

Going to push as commit f015733.
Since your change was applied there have been 58 commits pushed to the master branch:

64da862: 8287597: List all preview features on the javadoc PREVIEW page
b4e1e41: 8293000: Review running times of jshell regression tests
6d83482: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts
6974978: 8294521: Parallel: Remove unused field in UpdateDensePrefixAndCompactionTask
81fda1b: 8294569: Remove CardTable::_last_valid_index
7c60e6d: 8293770: RISC-V: Reuse runtime call trampolines
9dce865: 8294115: JNI local refs exceeds capacity warning in NetworkInterface::getAll
b030c7d: 8225235: Unused field defaultIndex in NetworkInterface
a07975b: 8294519: (fs) java/nio/file/Files/CopyProcFile.java fails intermittenly due to unstable /proc/cpuinfo output
88062ee: 8293969: breakup the long signature in SystemDictionaryShared::is_supported_invokedynamic
... and 48 more: https://git.openjdk.org/jdk/compare/aa48705dddee674baa479f5128cfc3b426d87d2d...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-09-30T12:46:05Z

@naotoj @satoyoshiki Pushed as commit f015733.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

1st commit for tz2022d

9c69fde

openjdk bot changed the title ~~1st commit for tz2022d~~ 8294357: (tz) Update Timezone Data to 2022d Sep 28, 2022

reverting irrelvant change in pom.xml

a3a5a5f

openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Sep 28, 2022

naotoj reviewed Sep 28, 2022

View reviewed changes

Added minor changes in comment lines

a896323

satoyoshiki marked this pull request as ready for review September 30, 2022 00:30

openjdk bot added the rfr Pull request is ready for review label Sep 30, 2022

naotoj reviewed Sep 30, 2022

View reviewed changes

coffeys approved these changes Sep 30, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 30, 2022

openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 30, 2022

naotoj approved these changes Sep 30, 2022

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Sep 30, 2022

openjdk bot closed this Sep 30, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8294357: (tz) Update Timezone Data to 2022d #10460

8294357: (tz) Update Timezone Data to 2022d #10460

satoyoshiki commented Sep 28, 2022 •

edited by openjdk bot

bridgekeeper bot commented Sep 28, 2022

satoyoshiki commented Sep 28, 2022

openjdk bot commented Sep 28, 2022

openjdk bot commented Sep 28, 2022

naotoj left a comment

naotoj Sep 28, 2022

naotoj Sep 28, 2022

mlbridge bot commented Sep 30, 2022

naotoj Sep 30, 2022

satoyoshiki Sep 30, 2022

naotoj Sep 30, 2022

coffeys left a comment

openjdk bot commented Sep 30, 2022 •

edited

satoyoshiki commented Sep 30, 2022

openjdk bot commented Sep 30, 2022

naotoj commented Sep 30, 2022

openjdk bot commented Sep 30, 2022

openjdk bot commented Sep 30, 2022

8294357: (tz) Update Timezone Data to 2022d #10460

8294357: (tz) Update Timezone Data to 2022d #10460

Conversation

satoyoshiki commented Sep 28, 2022 • edited by openjdk bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Sep 28, 2022

satoyoshiki commented Sep 28, 2022

openjdk bot commented Sep 28, 2022

openjdk bot commented Sep 28, 2022

naotoj left a comment

Choose a reason for hiding this comment

naotoj Sep 28, 2022

Choose a reason for hiding this comment

naotoj Sep 28, 2022

Choose a reason for hiding this comment

mlbridge bot commented Sep 30, 2022

Webrevs

naotoj Sep 30, 2022

Choose a reason for hiding this comment

satoyoshiki Sep 30, 2022

Choose a reason for hiding this comment

naotoj Sep 30, 2022

Choose a reason for hiding this comment

coffeys left a comment

Choose a reason for hiding this comment

openjdk bot commented Sep 30, 2022 • edited

satoyoshiki commented Sep 30, 2022

openjdk bot commented Sep 30, 2022

naotoj commented Sep 30, 2022

openjdk bot commented Sep 30, 2022

openjdk bot commented Sep 30, 2022

satoyoshiki commented Sep 28, 2022 •

edited by openjdk bot

openjdk bot commented Sep 30, 2022 •

edited