6616245: NullPointerException when using JFileChooser with a custom FileView #10485

TejeshR13 · 2022-09-29T11:12:41Z

When a custom FileView is used and folder traversal is restricted to a particular directory NPE occurs when user tries to traverse/select other folders except traversable folder. This is caused because when user selects folder other than traversable, the traversal is rejected and hence no file is selected as currentDirectory of JFileChooser. When user tries to access the restricted folder second time, previous selected file check is failing because of NPE since getFileChooser().getCurrentDirectory(); is null. To fix the issue, NPE check is added.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-6616245: NullPointerException when using JFileChooser with a custom FileView

Reviewers

Alexey Ivanov (@aivanov-jdk - Reviewer)
@kumarabhi006 (no known github.com user name / role) ⚠️ Review applies to f5d345e5

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10485/head:pull/10485
$ git checkout pull/10485

Update a local copy of the PR:
$ git checkout pull/10485
$ git pull https://git.openjdk.org/jdk pull/10485/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10485

View PR using the GUI difftool:
$ git pr show -t 10485

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10485.diff

bridgekeeper · 2022-09-29T11:14:54Z

👋 Welcome back tr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-09-29T11:17:44Z

@TejeshR13 The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-09-29T11:21:53Z

Webrevs

kumarabhi006 · 2022-09-30T07:44:31Z

The instruction are not quite clear. Can you please modify it as we discussed over call?

TejeshR13 · 2022-09-30T10:57:29Z

The instruction are not quite clear. Can you please modify it as we discussed over call?

Updated.

TejeshR13 · 2022-10-03T09:02:42Z

@kumarabhi006 Can you please review this PR.

TejeshR13 · 2022-10-03T09:10:45Z

@azuev-java Can you please review this PR.

aivanov-jdk

You say that the current directory in JFileChooser gets set to null because of forbidden navigation to a folder which is not traversable. You avoid the NPE by a null-check.

However, you should prevent the current directory to be set to null. If navigation is not allowed, the current directory should remain unchanged instead of being reset to null.

aivanov-jdk · 2022-10-03T11:02:32Z

src/java.desktop/share/classes/javax/swing/plaf/metal/MetalFileChooserUI.java

-            if (!getFileChooser().getCurrentDirectory().equals(f)) {
+            File curDir = getFileChooser().getCurrentDirectory();
+
+            if (curDir != null && !curDir.equals(f)) {


If f is always not null, you can you use !f.equals(curDir).

Prevention of not setting to null means I have to modify JFileChooser class itself, so just handling here. And yeahfcan't be null, can do that.

Why is it bad to modify JFileChooser class itself?

I think setting the current directory to null while it displays a directory kind of breaks the invariant.

JFileChooser navigated to a directory and the current directory is set to it. You tried navigating to another directory, FileSystem didn't allow the navigation, so JFileChooser continues to display the files in the directory that is showed before. Thus, the current directory hasn't changed. From this point of view, the current directory should remain unchanged.

jdk/src/java.desktop/share/classes/javax/swing/JFileChooser.java

Line 608 in ccc1d31

currentDirectory = dir;

Here the above logic checks if the current selected directory is traversable and if not it goes up to parent directory till top level and when every check fails then null is set to currentDirectory. Should we think of modifying this logic to not to set to null, rather remain in previously valid folder......?

Well, the logic there tries to prevent the current directory from becoming null. Yet it traverses up the tree:

jdk/src/java.desktop/share/classes/javax/swing/JFileChooser.java

Lines 603 to 607 in ccc1d31

File prev = null;

while (!isTraversable(dir) && prev != dir) {

prev = dir;

dir = getFileSystemView().getParentDirectory(dir);

}

Probably, if dir becomes null in the end, it should resort to its default behaviour: getFileSystemView().getDefaultDirectory(). Or not change at all?

Then, you can handle the situation here: if getFileChooser().getCurrentDirectory() returns null, restore the previous current directory.

And what about other L&F? If the same code runs in Windows L&F, Nimbus L&F, any other?

In other L&F the same problem exist, but NPE is does not occurs because previous state check is not done, directly the clicked file is been set.

jdk/src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsFileChooserUI.java

Line 1328 in ccc1d31

getFileChooser().setCurrentDirectory(f);

Well, the logic there tries to prevent the current directory from becoming null. Yet it traverses up the tree:

jdk/src/java.desktop/share/classes/javax/swing/JFileChooser.java

Lines 603 to 607 in ccc1d31

File prev = null;

while (!isTraversable(dir) && prev != dir) {

prev = dir;

dir = getFileSystemView().getParentDirectory(dir);

}

Probably, if dir becomes null in the end, it should resort to its default behaviour: getFileSystemView().getDefaultDirectory(). Or not change at all?

This behaviour is specified.

jdk/src/java.desktop/share/classes/javax/swing/JFileChooser.java

Lines 576 to 580 in ccc1d31

* If the file passed in as <code>currentDirectory</code> is not a

* directory, the parent of the file will be used as the currentDirectory.

* If the parent is not traversable, then it will walk up the parent tree

* until it finds a traversable directory, or hits the root of the

* file system.

Yet it doesn't take into account a custom implementation of FileSystem which does not allow navigating up. It may be a problem in FileSystem implementation.

In other L&F the same problem exist, but NPE is does not occurs because previous state check is not done, directly the clicked file is been set.

jdk/src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsFileChooserUI.java

Line 1328 in ccc1d31

getFileChooser().setCurrentDirectory(f);

Maybe it's the way to go for Metal too? I mean call setCurrentDirectory unconditionally.

What do other L&Fs do?

In other L&F, null gets assigned to currentDirectory and NPE doesn't occur since that previous directory check is not done.

… NPE doesn't occur since that previous directory check is not done.

Then I suggest going this way and just drop the checks from Metal L&F.

The test should set Metal L&F explicitly. Or better yet, it should be run in all L&Fs to ensure NPE isn't thrown.

As for preserving the current value of currentDirectory if the passed in folder cannot be navigated to. I think it should be done yet it's a separate issue from this one. Shall I submit a new bug? Does anyone have an opinion on this?

aivanov-jdk · 2022-10-03T11:05:23Z

test/jdk/javax/swing/JFileChooser/FileViewNPETest.java

+        if ((filePath != null) && (filePath.isDirectory())) {
+            return filePath.getAbsolutePath().startsWith(basePath);
+        } else {
+            return false;
+        }


It can be simplified to:

Suggested change

if ((filePath != null) && (filePath.isDirectory())) {

return filePath.getAbsolutePath().startsWith(basePath);

} else {

return false;

}

return ((filePath != null) && (filePath.isDirectory())

&& filePath.getAbsolutePath().startsWith(basePath));

I'm not insisting though.

Can be done, no issues.

aivanov-jdk · 2022-10-03T11:06:14Z

test/jdk/javax/swing/JFileChooser/FileViewNPETest.java

+        jfc = new JFileChooser();
+        String path = "";
+        if (Platform.isWindows()) {
+            path = "C:" + File.separator + "temp";


It's rare but possible that Windows is installed not on C: drive.

Since temp will be better option without creating any new directory for the test, I didn't change it (it was reused from JBS report). Any other alternative......?

Why not request the path to the system temporary directory?

Temporary directory on Windows is not located in C:\temp. Likely this folder does not exist. You should use TMP or TEMP environment variable. Alternatively, you can use createTempFile from from java.io.File or java.nio.Files to create a file in the temp directory, its parent is the path to the temp directory.

User's home could be a better option. It's guaranteed to exist, user.home system property points to it. And it's a more real-life scenario.

Then I can just make user.home directory as the only traversable.......?

Makes sense to me.

aivanov-jdk · 2022-10-03T15:24:43Z

test/jdk/javax/swing/JFileChooser/FileViewNPETest.java

+ * @test
+ * @bug 6616245
+ * @key headful
+ * @requires (os.family == "windows" | os.family == "linux")


Is there a specific reason to exclude macOS? Is it only because the default L&F isn't Metal?

Yeah, was not able to reproduce in macOS.

You can set Metal L&F explicitly on macOS.

Yeah, I checked it now and the issue is reproducible in macOS also, have to update the test to include macOS.

Had thought that default L&F in macOS will be metal, didn't realize have to set it explicitly. My mistake, thank you @aivanov-jdk and @mrserb for pointing it out.

TejeshR13 · 2022-10-04T05:45:50Z

@aivanov-jdk I have updated as per the review comments. Please let me know if its fine. I have put up the mach5 test link in JBS for reference.

kumarabhi006 · 2022-10-10T05:53:54Z

@TejeshR13 Verified latest fix on ubuntu and fix is working fine.

mrserb · 2022-10-10T06:32:44Z

test/jdk/javax/swing/JFileChooser/FileViewNPETest.java

+
+        //Initialize the components
+        final String INSTRUCTIONS = """
+                Instructions to Test:


JFileChooser extends JComponent, probably we can create a frame with embedded JFileChooser and programmatically change the value of that "Look-In ComboBox"-> and catch an exception.

Means in Test INSTRUCTIONS a link to Look-In can be attached......?

Or suggesting to make the test automatic......?

@mrserb is suggesting making the test automatic. JFileChooser is embedded in a frame in the test. It should be possible… I'm fine with manual test though… for now.

Ok, since the test has to select non traversable folders in both windows and linux I had thought that making it as manual would be better.

Probably it will be good to automate it, and cover the macOS? I do not see a reason why we cannot set Metal L&F and verify the fix.

I wasn't able to reproduce the issue in macOS, so didn't include it in test...... And the fix is for metal L&F and should we explicitly set the L&F? Anyhow default L&F is metal right....?

Probably it will be good to automate it

I've submitted JDK-8295298: Automate javax/swing/JFileChooser/FileViewNPETest.java

… and cover the macOS? I do not see a reason why we cannot set Metal L&F and verify the fix.

Agreed.

I wasn't able to reproduce the issue in macOS, so didn't include it in test...... And the fix is for metal L&F and should we explicitly set the L&F? Anyhow default L&F is metal right....?

The default Look and Feel is Metal except for macOS where the default one is Aqua which is the system L&F. The default L&F can be changed using a property file or setting the system property.

You can always change the L&F in the code.

Ok will check in macOS again then.

Sorry, I had not set Metal L&F while checking in macOS, the is reproducible in macOS also, and the test case has to be updated for macOS.

aivanov-jdk · 2022-10-10T11:24:43Z

test/jdk/javax/swing/JFileChooser/FileViewNPETest.java

+        jfc = new JFileChooser();
+        String path = System.getProperty("user.home");


The test does not work for me on Windows. It starts with user.home as the current folder as expected; when select C:\, it goes to Desktop which is the root of the Shell namespace.

I guess, you have to change it to System.getProperty("user.home") + File.separator + "Documents" as you and I discussed. It'll make Desktop unreachable.

On Linux, the test works correctly.

aivanov-jdk · 2022-10-10T11:24:55Z

test/jdk/javax/swing/JFileChooser/FileViewNPETest.java

+}
+
+class CustomFileView extends FileView {
+    private String basePath;


Suggested change

private String basePath;

private final String basePath;

aivanov-jdk · 2022-10-10T11:26:16Z

test/jdk/javax/swing/JFileChooser/FileViewNPETest.java

+        return ((filePath != null) && (filePath.isDirectory())) &&
+                filePath.getAbsolutePath().startsWith(basePath);


Suggested change

return ((filePath != null) && (filePath.isDirectory())) &&

filePath.getAbsolutePath().startsWith(basePath);

return ((filePath != null) && (filePath.isDirectory()))

&& filePath.getAbsolutePath().startsWith(basePath);

I prefer wrapping before the operator, it makes it clear that it's a continuation line. Java Coding Style suggests wrapping this way.

aivanov-jdk · 2022-10-10T11:27:27Z

test/jdk/javax/swing/JFileChooser/FileViewNPETest.java

+
+        //Initialize the components
+        final String INSTRUCTIONS = """
+                Instructions to Test:


Yet you control which folders are non-traversable. Anyway… A test is better than no test; an automatic test is better than a manual one.

aivanov-jdk · 2022-10-10T16:14:56Z

test/jdk/javax/swing/JFileChooser/FileViewNPETest.java

+import javax.swing.WindowConstants;
+
+import javax.swing.filechooser.FileView;
+import jdk.test.lib.Platform;


It's not used any more, please remove.

Leave one blank line after the last import and the following comment with the jtreg tags.

aivanov-jdk · 2022-10-10T16:17:04Z

test/jdk/javax/swing/JFileChooser/FileViewNPETest.java

+ * @test
+ * @bug 6616245
+ * @key headful
+ * @requires (os.family == "windows" | os.family == "linux")


You can set Metal L&F explicitly on macOS.

aivanov-jdk · 2022-10-10T16:17:49Z

test/jdk/javax/swing/JFileChooser/FileViewNPETest.java

+ * @library /java/awt/regtesthelpers /test/lib
+ * @build PassFailJFrame jdk.test.lib.Platform


Suggested change

* @library /java/awt/regtesthelpers /test/lib

* @build PassFailJFrame jdk.test.lib.Platform

* @library /java/awt/regtesthelpers

* @build PassFailJFrame

Platform class from /test/lib is not used any more.

In mac the issue was not reproducible.....

aivanov-jdk · 2022-10-10T16:19:08Z

test/jdk/javax/swing/JFileChooser/FileViewNPETest.java

+        JFrame frame;
+        JFileChooser jfc;
+
+        //Initialize the components


I believe the comment is redundant. Being placed before the instruction text, it's confusing. The method name initialize is self-explanatory.

aivanov-jdk · 2022-10-10T16:21:18Z

test/jdk/javax/swing/JFileChooser/FileViewNPETest.java

+                Instructions to Test:
+                1. The traversable folder set is to "user/home" Directory,
+                 other than these folder all other
+                 folders are considered as non-traversable.
+                2. When file chooser appears on screen, select any
+                 non-traversable folder from "Look-In" ComboBox by mouse
+                 click/key press. (The folder will not be opened since its
+                 non-traversable). Select the same folder again.
+                3. If NPE occurs on second selection then test FAILS, else test
+                 is PASS.
+                """;


I propose the following text:

Instructions to Test: 1. The traversable folder is set to the Documents folder, if it exists, in the user's home folder, otherwise it's the user's home. Other folders are non-traversable. 2. When the file chooser appears on the screen, select any non-traversable folder from "Look-In" combo box, for example the user's folder or a folder above it. (The folder will not be opened since it's non-traversable). 3. Select the Documents folder again. 4. If NullPointerException occurs in the step 3, click Fail, otherwise click Pass.

It consistently uses “folder”, no mention of “directory”. It explains that the user's home could be the root of the traversable tree. The instructions use imperative to select either Fail or Pass.

4th point has been modified, since user can only select Pass, otherwise the test itself fails.

aivanov-jdk · 2022-10-10T16:22:20Z

test/jdk/javax/swing/JFileChooser/FileViewNPETest.java

+        frame = new JFrame("JFileChooser File View NPE test");
+        passFailJFrame = new PassFailJFrame("Test Instructions", INSTRUCTIONS, 5L, 13, 40);
+        jfc = new JFileChooser();
+        String path = System.getProperty("user.home") + File.separator + "Documents";


Suggested change

String path = System.getProperty("user.home") + File.separator + "Documents";

String userHome = System.getProperty("user.home");

String docs = userHome + File.separator + "Documents";

String path = (new File(docs).exists()) ? docs : userHome;

This will make the test more robust, it can continue to run even if Documents folder does not exist.

aivanov-jdk · 2022-10-10T16:26:15Z

test/jdk/javax/swing/JFileChooser/FileViewNPETest.java

+        String path = System.getProperty("user.home") + File.separator + "Documents";
+
+        jfc.setCurrentDirectory(new File(path));
+        jfc.setFileView(new CustomFileView(path));


Suggested change

jfc.setFileView(new CustomFileView(path));

jfc.setFileView(new CustomFileView(path));

jfc.setControlButtonsAreShown(false);

Hide Open and Cancel buttons in the file chooser.

aivanov-jdk

Looks good to me now.

aivanov-jdk · 2022-10-10T17:23:16Z

test/jdk/javax/swing/JFileChooser/FileViewNPETest.java

-        String path = System.getProperty("user.home") + File.separator + "Documents";
+        String userHome = System.getProperty("user.home");


I prefer a blank line here to logically separate dealing with paths from creating the components. But it's a nit.

openjdk · 2022-10-10T18:46:08Z

@TejeshR13 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6616245: NullPointerException when using JFileChooser with a custom FileView

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 138 new commits pushed to the master branch:

fba763f: 8291519: jdk/jfr/api/event/TestShouldCommit.java failed with Unexpected value of shouldCommit()
6053bf0: 8293782: Shenandoah: some tests failed on lock rank check
4435d56: 8282395: URL.openConnection can throw IOOBE
fe70487: 8294958: java/net/httpclient/ConnectTimeout tests are slow
97f1321: 8294356: IGV: scheduled graphs contain duplicated elements
5e05e42: 8294901: remove pre-VS2017 checks in Windows related coding
e775acf: 8293986: Incorrect double-checked locking in com.sun.beans.introspect.ClassInfo
9d116ec: 8294262: AArch64: compiler/vectorapi/TestReverseByteTransforms.java test failed on SVE machine
4b17d28: 8294261: AArch64: Use pReg instead of pRegGov when possible
891156a: 8295003: Do not mention applets in the "java.awt.color" package
... and 128 more: https://git.openjdk.org/jdk/compare/ce85cac947158b4e1f554c55f726c923a49b1a41...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

aivanov-jdk · 2022-10-11T07:46:06Z

test/jdk/javax/swing/JFileChooser/FileViewNPETest.java

+                4. If NullPointerException does not occurs in the step 3,
+                 click Pass, otherwise the Test Fails.


Suggested change

4. If NullPointerException does not occurs in the step 3,

click Pass, otherwise the Test Fails.

4. If NullPointerException does not occur in the step 3,

click Pass, otherwise the test fails automatically.

I guess this is better and has no grammar mistakes.

kumarabhi006 · 2022-10-11T07:52:42Z

test/jdk/javax/swing/JFileChooser/FileViewNPETest.java

+/*
+ * @test
+ * @bug 6616245
+ * @key headful


Is it required to have a key tag for manual test case?

Is it required to have a key tag for manual test case?

A manual test is declared by its @run tag:

* @run main/manual FileViewNPETest

If -a (automatic tests) is passed to jtreg, this test isn't selected for running.

Removed the tag.

I admit I misunderstood the question. I thought @kumarabhi006 had asked for adding another keyword to @key to specify a manual test.

I didn't think about removing @key headful. At the same time, a manual test implies being headful to the UI with instructions.

kumarabhi006 · 2022-10-11T07:57:26Z

test/jdk/javax/swing/JFileChooser/FileViewNPETest.java

+                 click Pass, otherwise the Test Fails.
+                """;
+        frame = new JFrame("JFileChooser File View NPE test");
+        passFailJFrame = new PassFailJFrame("Test Instructions", INSTRUCTIONS, 5L, 13, 40);


Few lines are going beyond 80 columns, can you please update them?

Few lines are going beyond 80 columns, can you please update them?

I agree, line 80 could be wrapped, it's 92 columns long. At the same, I wouldn't have insisted because it contains the parameters to PassFailJFrame which aren't so important to understanding the logic of the test.

Line 92 with the position is better left untouched, it's not too long (five chars outside of 80-column limit) and it's cleaner unwrapped. You may statically-import PassFailJFrame.Position in which case the line would become shorter:

PassFailJFrame.positionTestWindow(frame, Position.HORIZONTAL);

I am for keeping line 61 as it is now even though it doesn't fit the limit by 5 characters. It's still readable. In fact, this throws clause could be avoided altogether by restructuring the code. The constructor of PassFailJFrame is designed to be called on the main thread, yet Tejesh prefers it this way. I don't think it's worth moving the code around at this point when it's approved already.

kumarabhi006 · 2022-10-11T08:56:04Z

Verified the latest fix and is working fine.

aivanov-jdk · 2022-10-11T10:27:23Z

test/jdk/javax/swing/JFileChooser/FileViewNPETest.java

@@ -36,7 +36,6 @@
 /*
 * @test
 * @bug 6616245
- * @key headful


Why did you remove headful?

Added again, though some manual tests have this tag and some don't better to keep it as an indication that represents as headful test......

TejeshR13 · 2022-10-11T10:49:32Z

/integrate

openjdk · 2022-10-11T10:51:21Z

@TejeshR13
Your change (at version 5854ef2) is now ready to be sponsored by a Committer.

aivanov-jdk · 2022-10-11T11:10:16Z

/sponsor

openjdk · 2022-10-11T11:12:08Z

Going to push as commit 33d0618.
Since your change was applied there have been 138 commits pushed to the master branch:

fba763f: 8291519: jdk/jfr/api/event/TestShouldCommit.java failed with Unexpected value of shouldCommit()
6053bf0: 8293782: Shenandoah: some tests failed on lock rank check
4435d56: 8282395: URL.openConnection can throw IOOBE
fe70487: 8294958: java/net/httpclient/ConnectTimeout tests are slow
97f1321: 8294356: IGV: scheduled graphs contain duplicated elements
5e05e42: 8294901: remove pre-VS2017 checks in Windows related coding
e775acf: 8293986: Incorrect double-checked locking in com.sun.beans.introspect.ClassInfo
9d116ec: 8294262: AArch64: compiler/vectorapi/TestReverseByteTransforms.java test failed on SVE machine
4b17d28: 8294261: AArch64: Use pReg instead of pRegGov when possible
891156a: 8295003: Do not mention applets in the "java.awt.color" package
... and 128 more: https://git.openjdk.org/jdk/compare/ce85cac947158b4e1f554c55f726c923a49b1a41...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-10-11T11:12:23Z

@aivanov-jdk @TejeshR13 Pushed as commit 33d0618.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

fix

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

9b53979

openjdk bot added the rfr label Sep 29, 2022

openjdk bot added the client label Sep 29, 2022

Updated based on review comments

54ddc88

aivanov-jdk reviewed Oct 3, 2022

View reviewed changes

Updated based on review comments

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

a029903

Test case update

62f6c30

mrserb reviewed Oct 10, 2022

View reviewed changes

aivanov-jdk suggested changes Oct 10, 2022

View reviewed changes

Updated based on review comments

11a697e

aivanov-jdk suggested changes Oct 10, 2022

View reviewed changes

Updated based on review comments

cbc3ba1

aivanov-jdk approved these changes Oct 10, 2022

View reviewed changes

openjdk bot added the ready label Oct 10, 2022

Updated based on review comments

f5d345e

aivanov-jdk approved these changes Oct 11, 2022

View reviewed changes

kumarabhi006 reviewed Oct 11, 2022

View reviewed changes

kumarabhi006 approved these changes Oct 11, 2022

View reviewed changes

Updated based on review comments

de312f5

aivanov-jdk suggested changes Oct 11, 2022

View reviewed changes

openjdk bot removed the ready label Oct 11, 2022

Updated based on review comments

5854ef2

aivanov-jdk approved these changes Oct 11, 2022

View reviewed changes

openjdk bot added ready sponsor labels Oct 11, 2022

openjdk bot added the integrated label Oct 11, 2022

openjdk bot closed this Oct 11, 2022

openjdk bot removed ready rfr sponsor labels Oct 11, 2022

aivanov-jdk mentioned this pull request Oct 20, 2022

8295298: Automate javax/swing/JFileChooser/FileViewNPETest.java #10801

Closed

3 tasks

	File prev = null;
	while (!isTraversable(dir) && prev != dir) {
	prev = dir;
	dir = getFileSystemView().getParentDirectory(dir);
	}

	* If the file passed in as <code>currentDirectory</code> is not a
	* directory, the parent of the file will be used as the currentDirectory.
	* If the parent is not traversable, then it will walk up the parent tree
	* until it finds a traversable directory, or hits the root of the
	* file system.

		jfc = new JFileChooser();
		String path = System.getProperty("user.home");

		return ((filePath != null) && (filePath.isDirectory())) &&
		filePath.getAbsolutePath().startsWith(basePath);

		* @library /java/awt/regtesthelpers /test/lib
		* @build PassFailJFrame jdk.test.lib.Platform

	jfc.setFileView(new CustomFileView(path));
	jfc.setFileView(new CustomFileView(path));
	jfc.setControlButtonsAreShown(false);

		String path = System.getProperty("user.home") + File.separator + "Documents";
		String userHome = System.getProperty("user.home");

		4. If NullPointerException does not occurs in the step 3,
		click Pass, otherwise the Test Fails.

6616245: NullPointerException when using JFileChooser with a custom FileView #10485

6616245: NullPointerException when using JFileChooser with a custom FileView #10485

Conversation

TejeshR13 commented Sep 29, 2022 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Sep 29, 2022

openjdk bot commented Sep 29, 2022

mlbridge bot commented Sep 29, 2022 • edited Loading

Webrevs

kumarabhi006 commented Sep 30, 2022

TejeshR13 commented Sep 30, 2022

TejeshR13 commented Oct 3, 2022 • edited Loading

TejeshR13 commented Oct 3, 2022

aivanov-jdk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TejeshR13 Oct 3, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aivanov-jdk Oct 3, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TejeshR13 commented Oct 4, 2022

kumarabhi006 commented Oct 10, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aivanov-jdk Oct 13, 2022 • edited Loading

Choose a reason for hiding this comment

TejeshR13 Oct 14, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aivanov-jdk left a comment

TejeshR13 commented Sep 29, 2022 •

edited by openjdk bot

Loading

mlbridge bot commented Sep 29, 2022 •

edited

Loading

TejeshR13 commented Oct 3, 2022 •

edited

Loading

TejeshR13 Oct 3, 2022 •

edited

Loading

aivanov-jdk Oct 3, 2022 •

edited

Loading

aivanov-jdk Oct 13, 2022 •

edited

Loading

TejeshR13 Oct 14, 2022 •

edited

Loading

openjdk bot commented Oct 10, 2022 •

edited

Loading

kumarabhi006 Oct 11, 2022 •

edited

Loading