8294151: JFR: Unclear exception message when dumping stopped in memory recording

[egahlin]

Hi

Could I have a review of a change that updates the specification for the Recording::dump(Path) method and the exception message if the method fails.

Testing: jdk/jdk/jfr

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires a CSR request to be approved

Issues

• JDK-8294151: JFR: Unclear exception message when dumping stopped in memory recording
• JDK-8294530: Update specification of jdk.jfr.consumer.Recording::dump(Path) in case of an in memory recording (CSR)

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10488/head:pull/10488
$ git checkout pull/10488

Update a local copy of the PR:
$ git checkout pull/10488
$ git pull https://git.openjdk.org/jdk pull/10488/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10488

View PR using the GUI difftool:
$ git pr show -t 10488

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10488.diff

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7a7ff7c0)

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294151: JFR: Unclear exception message when dumping stopped in memory recording

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 89 new commits pushed to the master branch:

• b4e74ae: 8294514: Wrong initialization of nmethod::_consts_offset for native nmethods
• 953ce8d: 8293701: jdeps InverseDepsAnalyzer runs into NoSuchElementException: No value present
• be82cff: 8294748: Cleanup unneeded references to hg
• 43dbf58: 8186765: Speed up test sun/net/www/protocol/https/HttpsClient/ProxyAuthTest.java
• 755958e: 8294376: Minimize disabled warnings in java.base
• 1dafbe3: 8294539: Augment discussion of equivalence relations on floating-point values
• b2e86a6: 8294255: Add link to DEFAULT_WAIT_TIME in javadoc for SunToolKit.realsSync
• b22a38d: 8292309: Fix java/awt/PrintJob/ConstrainedPrintingTest/ConstrainedPrintingTest.java test
• 121d4a5: 8293579: tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java fails on Japanese Windows platform
• 1166a8a: 8292214: Memory leak in getAllConfigs of awt_GraphicsEnv.c:386
• ... and 79 more: https://git.openjdk.org/jdk/compare/1ea0d6b424c263590fd145913280a180d7ce5fe1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

Going to push as commit 13a5000.
Since your change was applied there have been 91 commits pushed to the master branch:

• 8ebebbc: 8294368: Java incremental builds broken on Windows after JDK-8293116
• 4bdd1c9: 8290964: C2 compilation fails with assert "non-reduction loop contains reduction nodes"
• b4e74ae: 8294514: Wrong initialization of nmethod::_consts_offset for native nmethods
• 953ce8d: 8293701: jdeps InverseDepsAnalyzer runs into NoSuchElementException: No value present
• be82cff: 8294748: Cleanup unneeded references to hg
• 43dbf58: 8186765: Speed up test sun/net/www/protocol/https/HttpsClient/ProxyAuthTest.java
• 755958e: 8294376: Minimize disabled warnings in java.base
• 1dafbe3: 8294539: Augment discussion of equivalence relations on floating-point values
• b2e86a6: 8294255: Add link to DEFAULT_WAIT_TIME in javadoc for SunToolKit.realsSync
• b22a38d: 8292309: Fix java/awt/PrintJob/ConstrainedPrintingTest/ConstrainedPrintingTest.java test
• ... and 81 more: https://git.openjdk.org/jdk/compare/1ea0d6b424c263590fd145913280a180d7ce5fe1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit 13a5000.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.