New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8294533: Documentation mistake in Process::getErrorStream and getInputStream #10492
Conversation
…tStream Correct javadoc links and references.
👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into |
@RogerRiggs The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@RogerRiggs This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit d207da8.
Your commit was automatically rebased without conflicts. |
@RogerRiggs Pushed as commit d207da8. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Correct javadoc links and references.
The links should refer to the method
()
instead of field.The apiNote in
getErrorStream
should refer to the error stream not the input stream and reader.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10492/head:pull/10492
$ git checkout pull/10492
Update a local copy of the PR:
$ git checkout pull/10492
$ git pull https://git.openjdk.org/jdk pull/10492/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10492
View PR using the GUI difftool:
$ git pr show -t 10492
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10492.diff