-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8186765: Speed up test sun/net/www/protocol/https/HttpsClient/ProxyAuthTest.java #10539
Conversation
/issue add 8280104 |
👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into |
@djelinski |
@djelinski The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC the test attempts to connect through a proxy to a server. The proxy needs Basic authentication. There is a system property that will allow/restrict which authentication scheme can be used with a proxy, and the test is run with various settings of that property. If the property doesn't allow the Basic authentication scheme, then the connection through the proxy will not succeed, and the proxy will never forward the request to the server.
So in the case where we expect that the client stack will reject the request (since the proxy wants Basic) there's no need to start the server - it will never receive any connection anyway.
This LGTM - but it might be good to have someone from security-dev chime in - I'm not too familiar with this SSLSocketTemplate class.
@djelinski This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 20 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thank you Daniel for that explanation. Having looked at the test, it wasn't clear to me what exactly was being done/tested there. @djelinski, the change looks fine to me. Although we now default to a well known port to which perhaps something already might be listening on a host, based on what Daniel noted, the request will never make it to that target - so this change will not introduce any intermittent failures from what I can see. The copyright year on that test file will need an update. |
Thanks, copyright updated. /issue remove 8280104 |
@djelinski |
/integrate |
Going to push as commit 43dbf58.
Your commit was automatically rebased without conflicts. |
@djelinski Pushed as commit 43dbf58. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR reduces the execution time of ProxyAuthTest.
Before this change the test always required at least 3 minutes to complete (6x 30 seconds timeout in
SSLSocketTemplate
'ssslServerSocket.accept()
).After this change the test does not open a server socket when it is not necessary.
The test continues to pass.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10539/head:pull/10539
$ git checkout pull/10539
Update a local copy of the PR:
$ git checkout pull/10539
$ git pull https://git.openjdk.org/jdk pull/10539/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10539
View PR using the GUI difftool:
$ git pr show -t 10539
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10539.diff