8294670: Enhanced switch statements have an implicit default which does not complete normally

[lahodaj]

When a synthetic default is generated for enhanced switch, it never completes normally, which should be used when detecting liveness after the switch statement, which is what this patch is trying to do.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8294670: Enhanced switch statements have an implicit default which does not complete normally

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10540/head:pull/10540
$ git checkout pull/10540

Update a local copy of the PR:
$ git checkout pull/10540
$ git pull https://git.openjdk.org/jdk pull/10540/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10540

View PR using the GUI difftool:
$ git pr show -t 10540

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10540.diff

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lahodaj The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (8b2060ac)

[vicente-romero-oracle]

looks good to me

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294670: Enhanced switch statements have an implicit default which does not complete normally

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 236 new commits pushed to the master branch:

• 0233ba7: 8284614: on macOS "spindump" should be run from failure_handler as root
• 2a799e5: 8285306: Fix typos in java.desktop
• d1f7945: 6924219: (fc spec) FileChannel.write(ByteBuffer, position) behavior when file opened for append not specified
• 5dbd495: 8295457: Make the signatures of write barrier methods consistent
• 7b2e83b: 8295469: S390X: Optimized builds are broken
• 63867c4: 8295433: EpsilonHeap doesn't need to override post_initialize()
• e7375f9: 8295468: RISC-V: Minimal builds are broken
• bd41428: 8293590: Some syntax checks performed by URL.openConnection() could be performed earlier, at URL construction
• 78fed9d: 7175397: The divider color is not changed to green when dragging for Nimbus LaF.
• 8c40b7d: 8292177: InitialSecurityProperty JFR event
• ... and 226 more: https://git.openjdk.org/jdk/compare/64da8620e154e0fe556c7b82547915595d014188...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lahodaj]

/integrate

[openjdk]

Going to push as commit 7bc9692.
Since your change was applied there have been 278 commits pushed to the master branch:

• 95dd376: 8291914: generated constructors are considered compact when they shouldn't
• 9b97162: 7039014: Confusing error message for method conflict
• 78dc497: 8294550: Sealed check for casts isn't applied to array components
• c08ff2c: 8294705: Disable an assertion in test/jdk/java/util/DoubleStreamSums/CompensatedSums.java
• d5a1521: 8295470: Update openjdk.java.net => openjdk.org URLs in test code
• 9d0cfd1: 8294948: Document IllegalArgumentException and NullPointerException thrown by URLStreamHandler::parseURL and URLStreamHandler::setURL
• dcd4650: 8294916: Cancelling a request must eventually cause its response body subscriber to be unregistered
• 4f994c0: 8295709: Linux AArch64 builds broken after JDK-8294438
• 545021b: 8294438: Fix misleading-indentation warnings in hotspot
• c5e0464: 8291456: com/sun/jdi/ClassUnloadEventTest.java failed with: Wrong number of class unload events: expected 10 got 4
• ... and 268 more: https://git.openjdk.org/jdk/compare/64da8620e154e0fe556c7b82547915595d014188...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lahodaj Pushed as commit 7bc9692.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.