New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8294740: Add cgroups keyword to TestDockerBasic.java #10547
8294740: Add cgroups keyword to TestDockerBasic.java #10547
Conversation
👋 Welcome back iklam! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and trivial. Thanks for the quick fix.
@iklam This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Thanks @dholmes-ora and @mseledts for the review. |
Going to push as commit ae79af2. |
Please review this trivial fix. TestDockerBasic.java uses cgroups features so it should be tagged with
@key cgroups
.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10547/head:pull/10547
$ git checkout pull/10547
Update a local copy of the PR:
$ git checkout pull/10547
$ git pull https://git.openjdk.org/jdk pull/10547/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10547
View PR using the GUI difftool:
$ git pr show -t 10547
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10547.diff