-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8294748: Cleanup unneeded references to hg #10554
Conversation
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
Webrevs
|
make/common/MakeBase.gmk
Outdated
@@ -127,14 +127,14 @@ endef | |||
# the build was created from | |||
SOURCE_REVISION_TRACKER := $(SUPPORT_OUTPUTDIR)/src-rev/source-revision-tracker | |||
|
|||
# Locate all hg repositories included in the forest, as absolute paths | |||
# Locate all sourcecode repositories included in the forest, as absolute paths | |||
FindAllReposAbs = \ | |||
$(strip $(sort $(dir $(filter-out $(TOPDIR)/build/%, $(wildcard \ | |||
$(addprefix $(TOPDIR)/, .hg */.hg */*/.hg */*/*/.hg */*/*/*/.hg) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should be possible to remove as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Erik, thanks for the remark. I removed the line.
@MBaesken This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Hi Erik, thanks for approving ; do we need a second review or is it sufficient now ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for the cleanup.
/integrate |
Going to push as commit be82cff.
Your commit was automatically rebased without conflicts. |
There are still a number of unneeded references to hg, for example
make/autoconf/spec.gmk.in
772 HG:=@hg@
make/autoconf/basic_tools.m4
345 UTIL_LOOKUP_PROGS(HG, hg)
Those can be cleaned up.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10554/head:pull/10554
$ git checkout pull/10554
Update a local copy of the PR:
$ git checkout pull/10554
$ git pull https://git.openjdk.org/jdk pull/10554/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10554
View PR using the GUI difftool:
$ git pr show -t 10554
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10554.diff