8294920: Missing SP value in Linux x86_32 thread context

[shipilev]

See the description in the bug. This fixes only Linux x86_32, because only there I could reproduce the failure. Windows x86_32 seems to be fine. I have no access to BSD x86_32.

Additional testing:

• Linux x86 fastdebug serviceability/sa now cleanly passes

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8294920: Missing SP value in Linux x86_32 thread context

Reviewers

• Chris Plummer (@plummercj - Reviewer)
• Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10598/head:pull/10598
$ git checkout pull/10598

Update a local copy of the PR:
$ git checkout pull/10598
$ git pull https://git.openjdk.org/jdk pull/10598/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10598

View PR using the GUI difftool:
$ git pr show -t 10598

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10598.diff

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (1d15b7db)
• 00: Full (ee181761)

[plummercj]

JDK-8208091 also addressed windows-x86. Any reason not to do the same here? I see bsd-x86 was neglected for JDK-8208091. Would have been nice if it hadn't been just to keep the ports consistent, although I'm not sure if anyone cares about bsd-x86.

[shipilev]

JDK-8208091 also addressed windows-x86. Any reason not to do the same here? I see bsd-x86 was neglected for JDK-8208091. Would have been nice if it hadn't been just to keep the ports consistent, although I'm not sure if anyone cares about bsd-x86.

I tested Windows x86_32, and the test passes there without this fix. I think this is Linux-specific, given how ESP/UESP split exists there? So, I opted to fix only the actual bugs that I was able to reproduce.

[plummercj]

Please update the copyright before integrating.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294920: Missing SP value in Linux x86_32 thread context

Reviewed-by: cjplummer, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

• c1166a3: 8289561: java/lang/instrument/NativeMethodPrefixAgent.java fails with "ERROR: Injection failure: java.lang.UnsupportedOperationException: Records requires ASM8"
• a1747ef: 8294941: GHA: Cut down cross-compilation sysroots
• 67210ab: 8286394: Address possibly lossy conversions in jdk.naming.dns
• 7a194d3: 8290154: [JVMCI] partially implement JVMCI for RISC-V
• b38bed6: 8294308: Allow dynamically choosing the MEMFLAGS of a type without ResourceObj
• 118d93b: 8294907: Remove unused NativeLookup::dll_load
• 1fda842: 8291429: java/lang/Thread/virtual/ThreadAPI.java timed out on single core system
• 2d25c0a: 8292280: Unused field 'keyListener' in BasicRadioButtonUI
• 0ad6803: 8293810: Remove granting of RuntimePermission("stopThread") from tests
• cf84c8e: 8292975: javac produces code that crashes with LambdaConversionException
• ... and 9 more: https://git.openjdk.org/jdk/compare/2ceebf681ffd6f9bf6967fd81b30d721bc010b94...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Thanks! I am integrating to hopefully get cleaner weekend test runs.

/integrate

[openjdk]

Going to push as commit fe7a461.
Since your change was applied there have been 20 commits pushed to the master branch:

• 4cbac40: 8294717: (bf) DirectByteBuffer constructor will leak if allocating Deallocator or Cleaner fails with OOME
• c1166a3: 8289561: java/lang/instrument/NativeMethodPrefixAgent.java fails with "ERROR: Injection failure: java.lang.UnsupportedOperationException: Records requires ASM8"
• a1747ef: 8294941: GHA: Cut down cross-compilation sysroots
• 67210ab: 8286394: Address possibly lossy conversions in jdk.naming.dns
• 7a194d3: 8290154: [JVMCI] partially implement JVMCI for RISC-V
• b38bed6: 8294308: Allow dynamically choosing the MEMFLAGS of a type without ResourceObj
• 118d93b: 8294907: Remove unused NativeLookup::dll_load
• 1fda842: 8291429: java/lang/Thread/virtual/ThreadAPI.java timed out on single core system
• 2d25c0a: 8292280: Unused field 'keyListener' in BasicRadioButtonUI
• 0ad6803: 8293810: Remove granting of RuntimePermission("stopThread") from tests
• ... and 10 more: https://git.openjdk.org/jdk/compare/2ceebf681ffd6f9bf6967fd81b30d721bc010b94...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit fe7a461.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.