8294931 JFR: Simplify SettingInfo

[egahlin]

Hi,

Could I have a review of a PR that simplifies code related to SettingInfo.

Testing: jdk/jdk/jfr

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8294931: JFR: Simplify SettingInfo

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10599/head:pull/10599
$ git checkout pull/10599

Update a local copy of the PR:
$ git checkout pull/10599
$ git pull https://git.openjdk.org/jdk pull/10599/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10599

View PR using the GUI difftool:
$ git pr show -t 10599

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10599.diff

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (5785880b)
• 00: Full (483b395e)

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294931: JFR: Simplify SettingInfo

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

• eb90c4f: 8294377: Prepare to stop auto-inheriting documentation for subclasses of exceptions whose documentation is inherited
• 4df4a1f: 8287832: jdk/jfr/event/runtime/TestActiveSettingEvent.java failed with "Expected two batches of Active Setting events"
• 35d17a0: 8293864: Kitchensink24HStress.java fails with SIGSEGV in JfrCheckpointManager::lease
• c5f462e: 8294956: GHA: qemu-debootstrap is deprecated, use the regular one
• 269252a: 8295007: javax/swing/JRadioButton/4314194/bug4314194.java fails in mach5 for WIndowLookAndFeel
• 6ed74ef: 8295005: compiler/loopopts/TestRemoveEmptyLoop.java fails with release VMs after JDK-8294839
• 8a148bc: 8294848: Unnecessary SSLCipher dispose implementations
• 8713dfa: 8294541: java/io/BufferedInputStream/TransferTo.java fails with OOME
• 542cc60: 8294366: RISC-V: Partially mark out incompressible regions
• 495c043: 7124710: interleaved RedefineClasses() and RetransformClasses() calls may have a problem
• ... and 18 more: https://git.openjdk.org/jdk/compare/d4c9a88073479ff05e6c07ed599c546826d6f6ba...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

Going to push as commit 1bfcc27.
Since your change was applied there have been 28 commits pushed to the master branch:

• eb90c4f: 8294377: Prepare to stop auto-inheriting documentation for subclasses of exceptions whose documentation is inherited
• 4df4a1f: 8287832: jdk/jfr/event/runtime/TestActiveSettingEvent.java failed with "Expected two batches of Active Setting events"
• 35d17a0: 8293864: Kitchensink24HStress.java fails with SIGSEGV in JfrCheckpointManager::lease
• c5f462e: 8294956: GHA: qemu-debootstrap is deprecated, use the regular one
• 269252a: 8295007: javax/swing/JRadioButton/4314194/bug4314194.java fails in mach5 for WIndowLookAndFeel
• 6ed74ef: 8295005: compiler/loopopts/TestRemoveEmptyLoop.java fails with release VMs after JDK-8294839
• 8a148bc: 8294848: Unnecessary SSLCipher dispose implementations
• 8713dfa: 8294541: java/io/BufferedInputStream/TransferTo.java fails with OOME
• 542cc60: 8294366: RISC-V: Partially mark out incompressible regions
• 495c043: 7124710: interleaved RedefineClasses() and RetransformClasses() calls may have a problem
• ... and 18 more: https://git.openjdk.org/jdk/compare/d4c9a88073479ff05e6c07ed599c546826d6f6ba...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit 1bfcc27.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.