Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java #10612

Closed
wants to merge 15 commits into from
+150 −1
Closed

8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java #10612

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c35f1af
Fix bundle name
justin-curtis-lu Oct 5, 2022
f346917
Add regression test for bundle name change
justin-curtis-lu Oct 7, 2022
609a6d0
Finalize test changes
justin-curtis-lu Oct 12, 2022
646ee97
Make fixes to validateGetBundle
justin-curtis-lu Oct 20, 2022
1ce2671
Run against US locale, fail test if exp not caught
justin-curtis-lu Oct 20, 2022
3e49163
Run Validate_.java in othervm mode
justin-curtis-lu Oct 20, 2022
c86950b
Remove stray binary file
justin-curtis-lu Oct 21, 2022
c67d789
Use @before, cleanup strings
justin-curtis-lu Oct 21, 2022
0aa978c
Remove unnecessary local String var
justin-curtis-lu Oct 21, 2022
1aa881b
Pass exception to constuctor directly
justin-curtis-lu Oct 21, 2022
2ea3e42
Clean up jtreg tags
justin-curtis-lu Oct 21, 2022
2e39c41
constant fix, better exception msg
justin-curtis-lu Oct 21, 2022
8f0b6ac
white space
justin-curtis-lu Oct 21, 2022
0f50339
Use data provider for getBundle test
justin-curtis-lu Oct 24, 2022
da3aeac
Move provider to top
justin-curtis-lu Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/jdk/javax/sql/resourceBundleTests/ValidateGetBundle.java
View file
Original file line number Diff line number Diff line change
@@ -58,8 +58,8 @@ private static void testResourceBundleAccess(String bundleName, boolean expectBu
var bundle = ResourceBundle.getBundle(bundleName,
Locale.US, JdbcRowSetResourceBundle.class.getModule());
if (!expectBundle) {
String message = "$$$ '%s' shouldn't have loaded!%n";
throw new RuntimeException(String.format(message, bundleName));
throw new RuntimeException(
String.format("$$$ Error: '%s' shouldn't have loaded!%n", bundleName));
}
System.out.printf("$$$ %s found as expected!%n", bundleName);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think expectBundle needs to be examined here. If it is false, it should throw an exception.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a check there for case when expectBundle is false

} catch (MissingResourceException mr) {