8279366: CDS should allow alternative locations for JAR files in classpath

[calvinccheung]

Please review this RFE for allowing alternative locations for jar files in the app classpath during runtime.

During dump time, the longest common prefix of the app classpath will be stored in the CDS archive header. During runtime, existing checks of the app classpath will be performed first. Upon failure, the longest common prefix of the runtime app classpath will be computed and another check of the app classpath will be performed ignoring the longest common prefix.

Refer to the bug report comment for an example.

Passed tiers 1 - 4 testing (including the new tests).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8279366: CDS should allow alternative locations for JAR files in classpath

Reviewers

• Ioi Lam (@iklam - Reviewer)
• Coleen Phillimore (@coleenp - Reviewer)
• @matias9927 (no known github.com user name / role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10615/head:pull/10615
$ git checkout pull/10615

Update a local copy of the PR:
$ git checkout pull/10615
$ git pull https://git.openjdk.org/jdk pull/10615/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10615

View PR using the GUI difftool:
$ git pr show -t 10615

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10615.diff

[calvinccheung]

/label add hotspot-runtime

[bridgekeeper]

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@calvinccheung
The hotspot-runtime label was successfully added.

[mlbridge]

Webrevs

• 03: Full - Incremental (59fad702)
• 02: Full - Incremental (11faf0cb)
• 01: Full - Incremental (d572c2e0)
• 00: Full (a8db37da)

[iklam]

LGTM

[openjdk]

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279366: CDS should allow alternative locations for JAR files in classpath

Reviewed-by: iklam, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 174 new commits pushed to the master branch:

• 6289600: 8295810: cleanup debug agent removeThread() api
• 5c4d99a: 8295118: G1: Clear CLD claim marks concurrently
• af2de97: 8287754: Update jib GNU make dependency on Windows to latest cygwin build
• 9051dde: 8294993: LingeredApp test update
• f37a605: 8295212: G1: Add wrapper for TruncatedSeqs that need separation by gc phase
• 6673cd8: 8295554: Move the "sizecalc.h" to the correct location
• 706d1b7: 8295798: (ch) Test java/nio/channels/Channels/ReadXBytes.java is very slow on Windows
• 89dafc0: 8292699: Improve printing of classes in native debugger
• 7520d0a: 8295855: ProblemList jdk/jshell/CommandCompletionTest.java on linux-all
• 1d15e5c: 8295716: Minimize disabled warnings in security libs
• ... and 164 more: https://git.openjdk.org/jdk/compare/90fb9a085bbaa9d1928a1cec9f00098b80577721...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[coleenp]

This looks correct to me.

[matias9927]

The changes look good!

[calvinccheung]

Thanks Ioi, Coleen, Matias for the review!

/integrate

[openjdk]

Going to push as commit 427f506.
Since your change was applied there have been 175 commits pushed to the master branch:

• 3a873d3: 8295808: GrowableArray should support capacity management
• 6289600: 8295810: cleanup debug agent removeThread() api
• 5c4d99a: 8295118: G1: Clear CLD claim marks concurrently
• af2de97: 8287754: Update jib GNU make dependency on Windows to latest cygwin build
• 9051dde: 8294993: LingeredApp test update
• f37a605: 8295212: G1: Add wrapper for TruncatedSeqs that need separation by gc phase
• 6673cd8: 8295554: Move the "sizecalc.h" to the correct location
• 706d1b7: 8295798: (ch) Test java/nio/channels/Channels/ReadXBytes.java is very slow on Windows
• 89dafc0: 8292699: Improve printing of classes in native debugger
• 7520d0a: 8295855: ProblemList jdk/jshell/CommandCompletionTest.java on linux-all
• ... and 165 more: https://git.openjdk.org/jdk/compare/90fb9a085bbaa9d1928a1cec9f00098b80577721...master

Your commit was automatically rebased without conflicts.

[openjdk]

@calvinccheung Pushed as commit 427f506.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.