New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8295288: Some vm_flags tests associate with a wrong BugID #10703
Conversation
👋 Welcome back caojoshua! A progress list of the required criteria for merging this PR into |
@caojoshua To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label add hotspot |
@caojoshua |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, and trivial.
@caojoshua This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@caojoshua |
/sponsor |
Going to push as commit 3dbc38a.
Your commit was automatically rebased without conflicts. |
@phohensee @caojoshua Pushed as commit 3dbc38a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Fixing incorrect bug IDs. IntxTest.java already has the correct bug ID, and SizeTTest has a different bug ID that is correct.
All changed tests passing locally.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10703/head:pull/10703
$ git checkout pull/10703
Update a local copy of the PR:
$ git checkout pull/10703
$ git pull https://git.openjdk.org/jdk pull/10703/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10703
View PR using the GUI difftool:
$ git pr show -t 10703
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10703.diff