Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295288: Some vm_flags tests associate with a wrong BugID #10703

Closed
wants to merge 1 commit into from

Conversation

caojoshua
Copy link
Contributor

@caojoshua caojoshua commented Oct 13, 2022

Fixing incorrect bug IDs. IntxTest.java already has the correct bug ID, and SizeTTest has a different bug ID that is correct.

All changed tests passing locally.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295288: Some vm_flags tests associate with a wrong BugID

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10703/head:pull/10703
$ git checkout pull/10703

Update a local copy of the PR:
$ git checkout pull/10703
$ git pull https://git.openjdk.org/jdk pull/10703/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10703

View PR using the GUI difftool:
$ git pr show -t 10703

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10703.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 13, 2022

👋 Welcome back caojoshua! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 13, 2022
@openjdk
Copy link

openjdk bot commented Oct 13, 2022

@caojoshua To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@caojoshua
Copy link
Contributor Author

/label add hotspot

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Oct 13, 2022
@openjdk
Copy link

openjdk bot commented Oct 13, 2022

@caojoshua
The hotspot label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Oct 13, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, and trivial.

@openjdk
Copy link

openjdk bot commented Oct 13, 2022

@caojoshua This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295288: Some vm_flags tests associate with a wrong BugID

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • b30d922: 8292876: Do not include the deprecated userinfo component of the URI in HTTP/2 headers
  • 2b4830a: 8295017: Remove Windows specific workaround in JLI_Snprintf
  • fdb74ed: 8295301: Problem list TrayIcon tests that fail on Ubuntu 22.04
  • 21407de: 8295173: (tz) Update Timezone Data to 2022e
  • f5f8df1: 8295295: CDS ArchivedEnumTest fails with StaticProperty::JAVA_LOCALE_USE_OLD_ISO_CODES
  • 18dd9ee: 8295025: (bf) ByteBuffer "Access to binary data" section suggests putFloat is void

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 13, 2022
@caojoshua
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 14, 2022
@openjdk
Copy link

openjdk bot commented Oct 14, 2022

@caojoshua
Your change (at version daadf5f) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 14, 2022

Going to push as commit 3dbc38a.
Since your change was applied there have been 14 commits pushed to the master branch:

  • ef5210f: 8295149: Misnomer for_young_gc instead of for_young_only_phase in G1Analytics
  • 64813f4: 8294850: Make rs length/pending card predictors dependent on gc phase
  • 21e4f06: 8295274: HelidonAppTest.java fails "assert(event->should_commit()) failed: invariant" from compiled frame"
  • f31c80d: 8294842: Pass actual pending cards to G1Policy::update_young_length_bounds during young gen revise
  • 7133fc9: 7172359: HTML parser StackOverflowError on invalid HTML:
  • tag inside an
  • 3d75e88: 8295270: RISC-V: Clean up and refactoring for assembler functions
  • be3b335: 8295026: Remove unused fields in StyleSheet
  • 67046ae: 8276687: Remove support for JDK 1.4.1 PerfData shared memory files
  • b30d922: 8292876: Do not include the deprecated userinfo component of the URI in HTTP/2 headers
  • 2b4830a: 8295017: Remove Windows specific workaround in JLI_Snprintf
  • ... and 4 more: https://git.openjdk.org/jdk/compare/4224d45132b98e4f7bb7a96b696692d2f0bf645e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 14, 2022
@openjdk openjdk bot closed this Oct 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 14, 2022
@openjdk
Copy link

openjdk bot commented Oct 14, 2022

@phohensee @caojoshua Pushed as commit 3dbc38a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
2 participants