-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8295239: Refactor java/util/Formatter/Basic script into a Java native test launcher #10715
Changes from 7 commits
a732f8c
f750adb
1cbca6e
089c6ba
bb01f86
fe67e05
5b9225c
148b3d3
9483f16
81fc6a3
00c32ee
56eae09
5a0ee74
676a102
781b352
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,86 @@ | ||
/* | ||
* Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
*/ | ||
|
||
import jdk.test.lib.process.OutputAnalyzer; | ||
import jdk.test.lib.process.ProcessTools; | ||
import java.io.IOException; | ||
import org.junit.jupiter.params.ParameterizedTest; | ||
import org.junit.jupiter.params.provider.ValueSource; | ||
|
||
|
||
|
||
/* @test | ||
* @summary Unit tests for formatter | ||
* @library /test/lib | ||
* @compile Basic.java | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For the record, I've not deduced how/why the rest of the .java files in the test get compiled to .class files... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I suspect because the other classes are in the test.src directory they are being compiled which can be verified by Justin looking at the jtr log for the test |
||
* @bug 4906370 4962433 4973103 4989961 5005818 5031150 4970931 4989491 5002937 | ||
* 5005104 5007745 5061412 5055180 5066788 5088703 6317248 6318369 6320122 | ||
* 6344623 6369500 6534606 6282094 6286592 6476425 5063507 6469160 6476168 | ||
* 8059175 8204229 | ||
* | ||
* @run junit BasicTestLauncher | ||
*/ | ||
public class BasicTestLauncher { | ||
// Locale flag for testJVM | ||
private static final String JAVA_OPTS = "-Djava.locale.providers=CLDR"; | ||
// Test class | ||
private static final String TEST_CLASS = "Basic"; | ||
|
||
|
||
/** | ||
* Executes Formatter Basic tests | ||
* @param timeZone the time zone to run tests against | ||
*/ | ||
@ParameterizedTest | ||
@ValueSource(strings = { "US/Pacific", "Asia/Novosibirsk" }) | ||
void testTimeZone(String timeZone) throws IOException{ | ||
System.out.printf("$$$ Testing against %s!%n", timeZone); | ||
OutputAnalyzer output = RunTest(timeZone); | ||
CheckTest(output); | ||
System.out.printf("$$$ %s passed as expected!%n", timeZone); | ||
} | ||
|
||
|
||
/** | ||
* Creates and runs the testJVM process using Basic class | ||
* @param timeZone the time zone to be set in the testJVM environment | ||
*/ | ||
private static OutputAnalyzer RunTest(String timeZone) throws IOException{ | ||
// Build and run Basic class with correct configuration | ||
ProcessBuilder pb = ProcessTools.createTestJvm(JAVA_OPTS, TEST_CLASS); | ||
pb.environment().put("TZ", timeZone); | ||
Process process = pb.start(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: indentation There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed, thanks! |
||
return new OutputAnalyzer(process); | ||
} | ||
|
||
|
||
/** | ||
* Validates if the testJVM process passed all tests | ||
* @param output is an Output Analyzer for the testJVM | ||
* @throws RuntimeException for all testJVM failures | ||
*/ | ||
private static void CheckTest(OutputAnalyzer output){ | ||
output.shouldHaveExitValue(0) | ||
.reportDiagnosticSummary(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: indentation |
||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
%d, yes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, will change that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And one on the previous line