8282463: javax/sound/sampled/Clip/DataPusherThreadCheck.java fails

[turbanoff]

Test failed on Ubuntu, because both implementations of MixerProvider have no devices:

1. com.sun.media.sound.DirectAudioDeviceProvider#nGetNumDevices returns 0
   
2. com.sun.media.sound.PortMixerProvider#nGetNumDevices returns 0
   

It leads to javax.sound.sampled.spi.MixerProvider#getMixerInfo returns empty array.

And DataPusher thread is not created, because of AudioSystem.isLineSupported returns false in the method com.sun.media.sound.JavaSoundAudioClip#createSourceDataLine.
I propose to perform the same check in test code and skip it.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8282463: javax/sound/sampled/Clip/DataPusherThreadCheck.java fails

Reviewers

• Phil Race (@prrace - Reviewer)
• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10717/head:pull/10717
$ git checkout pull/10717

Update a local copy of the PR:
$ git checkout pull/10717
$ git pull https://git.openjdk.org/jdk pull/10717/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10717

View PR using the GUI difftool:
$ git pr show -t 10717

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10717.diff

[bridgekeeper]

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@turbanoff The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (16fc662f)

[prrace]

So I have no real objection to this check because it will solve something - more on that at the end.

1. On my Ubuntu 22.04 system it passes this new condition you added - ie the device is present.
2. This test has been failing only very intermittently, which points to the failure mode in the test being that the DataPusher thread is created but is terminated before it can be observed.

Where I've seen the device not present is when running on some VM configs where there is no audio support - there the test will fail every time.
For that I think your check should cure the 100% failure, but will do nothing about the 1% (or less) failure.

That said .. the test doesn't call clip.stop() until after the verification, so perhaps there's something else going on.

[openjdk]

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282463: javax/sound/sampled/Clip/DataPusherThreadCheck.java fails

Reviewed-by: prr, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 183 new commits pushed to the master branch:

• a44ebd5: 8295849: Consolidate Threads::owning_thread*
• 1c86cf5: 8294672: Typo in description of JDWP VirtualMachine/AllThreads command
• 823fd4a: 8293785: Add a jtreg test for TraceOptoParse
• 754bd53: 8296030: compiler/c2/irTests/TestVectorizeTypeConversion.java fails with release VMs after JDK-8291781
• 1fdbb1b: 8295926: RISC-V: C1: Fix LIRGenerator::do_LibmIntrinsic
• cf5546b: 8291336: Add ideal rule to convert floating point multiply by 2 into addition
• 4b89fce: 8291781: assert(!is_visited) failed: visit only once with -XX:+SuperWordRTDepCheck
• d5d3424: 8295405: Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests
• fd668dc: 8295537: Enhance TRACE_METHOD_LINKAGE to show the target MethodHandle
• 182c215: 8295994: Remove left over InetAddressContainer class
• ... and 173 more: https://git.openjdk.org/jdk/compare/2087424736f15a5a80a0492993a6cd74da87188a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[prrace]

I remain un-convinced this has got to the bottom of the original reason for the bug but OK to push this and see what happens.

[turbanoff]

I wasn't able to reproduce failure after the fix.

/integrate

[openjdk]

Going to push as commit 2e71637.
Since your change was applied there have been 185 commits pushed to the master branch:

• f3ca0ca: 8293999: [JVMCI] need support for aligned constants in generated code larger than 8 bytes
• 8aa1526: 8285835: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work
• a44ebd5: 8295849: Consolidate Threads::owning_thread*
• 1c86cf5: 8294672: Typo in description of JDWP VirtualMachine/AllThreads command
• 823fd4a: 8293785: Add a jtreg test for TraceOptoParse
• 754bd53: 8296030: compiler/c2/irTests/TestVectorizeTypeConversion.java fails with release VMs after JDK-8291781
• 1fdbb1b: 8295926: RISC-V: C1: Fix LIRGenerator::do_LibmIntrinsic
• cf5546b: 8291336: Add ideal rule to convert floating point multiply by 2 into addition
• 4b89fce: 8291781: assert(!is_visited) failed: visit only once with -XX:+SuperWordRTDepCheck
• d5d3424: 8295405: Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests
• ... and 175 more: https://git.openjdk.org/jdk/compare/2087424736f15a5a80a0492993a6cd74da87188a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@turbanoff Pushed as commit 2e71637.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.