8295823: Use enhanced-for cycle instead of Enumeration in java.naming

[turbanoff]

java.util.Enumeration is a legacy interface from java 1.0.
There are couple of cycles which use it to iterate over collections. We can replace this manual cycle with enchanced-for, which is shorter and easier to read.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8295823: Use enhanced-for cycle instead of Enumeration in java.naming

Reviewers

• Aleksei Efimov (@AlekseiEfimov - Committer)
• Daniel Fuchs (@dfuch - Reviewer)
• Vyom Tewari (@vyommani - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10804/head:pull/10804
$ git checkout pull/10804

Update a local copy of the PR:
$ git checkout pull/10804
$ git pull https://git.openjdk.org/jdk pull/10804/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10804

View PR using the GUI difftool:
$ git pr show -t 10804

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10804.diff

[bridgekeeper]

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@turbanoff The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (22674a0e)

[AlekseiEfimov]

Hi Andrey,

The changes look reasonable to me.
The JNDI tests (JCK/regression) are also happy with it.

[dfuch]

LGTM

[openjdk]

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295823: Use enhanced-for cycle instead of Enumeration in java.naming

Reviewed-by: aefimov, dfuchs, vtewari

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

• 89dafc0: 8292699: Improve printing of classes in native debugger
• 7520d0a: 8295855: ProblemList jdk/jshell/CommandCompletionTest.java on linux-all
• 1d15e5c: 8295716: Minimize disabled warnings in security libs
• 8c86e92: 8295847: slow debug build error after JDK-8294466
• e122321: 8295844: jdk/test/whitebox/CPUInfoTest.java failed with "not all features are known: expected true, was false"
• df81b3c: 8295738: Automate javax/swing/JFileChooser/FileSizeCheck.java
• 68cf248: 8295298: Automate javax/swing/JFileChooser/FileViewNPETest.java
• fefbddf: 8291443: Obsolete the PrintSharedDictionary flag
• 5b3de6e: 8284840: Update CLDR to Version 42.0
• 2f3f3b6: 8295792: Clean up old async close code
• ... and 32 more: https://git.openjdk.org/jdk/compare/faa6b662577a24eeb726ba525303b68b87269869...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[vyommani]

Looks OK to me.

[turbanoff]

/integrate

[openjdk]

Going to push as commit 46e6aee.
Since your change was applied there have been 70 commits pushed to the master branch:

• 8e5d680: 8293093: NPE in P11KeyStore.getID
• 3135914: 8265441: IGV: select block nodes by clicking on it
• 78454b6: 8295879: JFR: Remove warnings in the jdk.jfr module
• 33ff80d: 8295402: G1: Tighten assertion in G1ScanHRForRegionClosure::scan_heap_roots
• 303548b: 8294752: G1: Remove redundant checks in check_obj_during_refinement
• cf121df: 8295889: NMT preinit code does not handle allocation errors
• 772be2e: 8295868: 32-bit Windows build failures after JDK-8294466
• e173fd7: 8295885: GHA: Bump gcc versions
• b2878c9: 8295710: remove os::dll_file_extension
• e3a5a34: 8295767: Remove unused fields in sun.awt.geom.Edge
• ... and 60 more: https://git.openjdk.org/jdk/compare/faa6b662577a24eeb726ba525303b68b87269869...master

Your commit was automatically rebased without conflicts.

[openjdk]

@turbanoff Pushed as commit 46e6aee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.