Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295762: [Vector API] Update generate_iota_indices for x86_32 after JDK-8293409 #10807

Closed
wants to merge 1 commit into from

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Oct 21, 2022

Hi all,

Many vector api tests fail on x86_32 after JDK-8293409 due to computing incorrect results.
The reason is that generate_iota_indices was updated only for x86_64 in JDK-8293409.
So let's fix it for x86_32.

Testing:

  • vector api tests on x86_32, all passed

Thanks.
Best regards,
Jie


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295762: [Vector API] Update generate_iota_indices for x86_32 after JDK-8293409

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10807/head:pull/10807
$ git checkout pull/10807

Update a local copy of the PR:
$ git checkout pull/10807
$ git pull https://git.openjdk.org/jdk pull/10807/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10807

View PR using the GUI difftool:
$ git pr show -t 10807

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10807.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 21, 2022

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 21, 2022
@openjdk
Copy link

openjdk bot commented Oct 21, 2022

@DamonFool The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Oct 21, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 21, 2022

Webrevs

@XiaohongGong
Copy link

Thanks for fixing it @DamonFool ! The change looks good to me!

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on change. I assume it is copy from 64-bit code.
But I am starting to concern about Vector API changes causing issues which were not caught during pre-integration testing.
Unfortunately these tests run in jdk_tier3 only. And as result are not part of GitHub Action testing. And in Oracle we don't test 32-bit.

May I suggest in addition to currently run tier1_part* in GHA add jdk_vector to it.
I looked on our internal testing times and all 3 tier1_part* and jdk_vector took about 5 min to run.

@DamonFool
Copy link
Member Author

Thanks for fixing it @DamonFool ! The change looks good to me!

Thanks @XiaohongGong for your review.

@DamonFool
Copy link
Member Author

I can't comment on change. I assume it is copy from 64-bit code.

Yes, it was copied from 64-bit code.

But I am starting to concern about Vector API changes causing issues which were not caught during pre-integration testing. Unfortunately these tests run in jdk_tier3 only. And as result are not part of GitHub Action testing. And in Oracle we don't test 32-bit.

May I suggest in addition to currently run tier1_part* in GHA add jdk_vector to it. I looked on our internal testing times and all 3 tier1_part* and jdk_vector took about 5 min to run.

Sounds good to me.
How about adding the vector api tests in GHA in a separate PR?
Thanks.

@vnkozlov
Copy link
Contributor

How about adding the vector api tests in GHA in a separate PR?

Yes, it is definitely separate changes.

@openjdk
Copy link

openjdk bot commented Oct 21, 2022

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295762: [Vector API] Update generate_iota_indices for x86_32 after JDK-8293409

Reviewed-by: xgong, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 21, 2022
@DamonFool
Copy link
Member Author

How about adding the vector api tests in GHA in a separate PR?

Yes, it is definitely separate changes.

Thanks @vnkozlov .
Will do it next week.
/integrate

@openjdk
Copy link

openjdk bot commented Oct 22, 2022

Going to push as commit adad59e.
Since your change was applied there have been 13 commits pushed to the master branch:

  • b5efa2a: 8294538: missing is_unloading() check in SharedRuntime::fixup_callers_callsite()
  • 6acbdb5: 8295427: popframe004: report more details on error
  • 902162c: 8295239: Refactor java/util/Formatter/Basic script into a Java native test launcher
  • f5dabf9: 8295088: Update External Spec page to show tabs for hosts
  • 2181042: 8295375: debug agent class tracking should not piggy back on the cbClassPrepare() callback
  • f41711e: 8295650: JFR: jfr scrub should warn if an event type doesn't exist
  • 0c13d66: 8295530: Update Zlib Data Compression Library to Version 1.2.13
  • 15bebf9: 8295666: Linux x86 build fails after 8292591
  • 5064718: 8294460: CodeSection::alignment checks for CodeBuffer::SECT_STUBS incorrectly
  • 8b010e0: 8030616: sun/management/jmxremote/bootstrap/RmiBootstrapTest fails intermittently with cannot find a free port
  • ... and 3 more: https://git.openjdk.org/jdk/compare/ef62b614d1760d198dcb7f5f0794fc3dc55587a7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 22, 2022
@openjdk openjdk bot closed this Oct 22, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 22, 2022
@openjdk
Copy link

openjdk bot commented Oct 22, 2022

@DamonFool Pushed as commit adad59e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DamonFool DamonFool deleted the JDK-8295762 branch October 22, 2022 03:52
@DamonFool
Copy link
Member Author

I can't comment on change. I assume it is copy from 64-bit code. But I am starting to concern about Vector API changes causing issues which were not caught during pre-integration testing. Unfortunately these tests run in jdk_tier3 only. And as result are not part of GitHub Action testing. And in Oracle we don't test 32-bit.

May I suggest in addition to currently run tier1_part* in GHA add jdk_vector to it. I looked on our internal testing times and all 3 tier1_part* and jdk_vector took about 5 min to run.

Here is the PR which adds the jdk_vector in GHA: #10879 .
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants