New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8295762: [Vector API] Update generate_iota_indices for x86_32 after JDK-8293409 #10807
Conversation
👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into |
@DamonFool The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Thanks for fixing it @DamonFool ! The change looks good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't comment on change. I assume it is copy from 64-bit code.
But I am starting to concern about Vector API changes causing issues which were not caught during pre-integration testing.
Unfortunately these tests run in jdk_tier3 only. And as result are not part of GitHub Action testing. And in Oracle we don't test 32-bit.
May I suggest in addition to currently run tier1_part*
in GHA add jdk_vector
to it.
I looked on our internal testing times and all 3 tier1_part*
and jdk_vector
took about 5 min to run.
Thanks @XiaohongGong for your review. |
Yes, it was copied from 64-bit code.
Sounds good to me. |
Yes, it is definitely separate changes. |
@DamonFool This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Thanks @vnkozlov . |
Going to push as commit adad59e.
Your commit was automatically rebased without conflicts. |
@DamonFool Pushed as commit adad59e. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Here is the PR which adds the jdk_vector in GHA: #10879 . |
Hi all,
Many vector api tests fail on x86_32 after JDK-8293409 due to computing incorrect results.
The reason is that
generate_iota_indices
was updated only for x86_64 in JDK-8293409.So let's fix it for x86_32.
Testing:
Thanks.
Best regards,
Jie
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10807/head:pull/10807
$ git checkout pull/10807
Update a local copy of the PR:
$ git checkout pull/10807
$ git pull https://git.openjdk.org/jdk pull/10807/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10807
View PR using the GUI difftool:
$ git pr show -t 10807
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10807.diff