Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295952: Problemlist existing compiler/rtm tests also on x86 #10875

Closed
wants to merge 1 commit into from

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Oct 26, 2022

Problemlist should be extended so that existing compiler/rtm entries include x86 (32-bit) intel builds as well, as these are also affected.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295952: Problemlist existing compiler/rtm tests also on x86

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10875/head:pull/10875
$ git checkout pull/10875

Update a local copy of the PR:
$ git checkout pull/10875
$ git pull https://git.openjdk.org/jdk pull/10875/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10875

View PR using the GUI difftool:
$ git pr show -t 10875

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10875.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 26, 2022

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 26, 2022
@openjdk
Copy link

openjdk bot commented Oct 26, 2022

@zzambers To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@zzambers
Copy link
Contributor Author

/label hotspot

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Oct 26, 2022
@openjdk
Copy link

openjdk bot commented Oct 26, 2022

@zzambers
The hotspot label was successfully added.

@zzambers
Copy link
Contributor Author

failures in GHA do not seem to be connected to this change

@mlbridge
Copy link

mlbridge bot commented Oct 26, 2022

Webrevs

@chhagedorn
Copy link
Member

/label add hotspot-compiler

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Nov 15, 2022
@openjdk
Copy link

openjdk bot commented Nov 15, 2022

@chhagedorn
The hotspot-compiler label was successfully added.

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial!

@openjdk
Copy link

openjdk bot commented Nov 15, 2022

@zzambers This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295952: Problemlist existing compiler/rtm tests also on x86

Reviewed-by: chagedorn, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 216 new commits pushed to the master branch:

  • 87530e6: 8296913: Correct enable preview idiom in JdbLastErrorTest.java
  • fafe682: 8295861: get rid of list argument in debug agent's removeNode() API
  • 216c6f6: 8294881: test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003/TestDescription.java fails
  • 6aef3a4: 8262435: Clarify the behavior of a few inherited ZipInputStream methods
  • c042b8e: 8294731: Improve multiplicative inverse for secp256r1 implementation
  • d3051a7: 8296736: Some PKCS9Attribute can be created but cannot be encoded
  • decb1b7: 8286800: Assert in PhaseIdealLoop::dump_real_LCA is too strong
  • c49e484: 8294739: jdk/jshell/ToolShiftTabTest.java timed out
  • a45c9af: 8295814: jdk/jshell/CommandCompletionTest.java fails with "lists don't have the same size expected [2] but found [1]"
  • d0fae43: 8294947: Use 64bit atomics in patch_verified_entry on x86_64
  • ... and 206 more: https://git.openjdk.org/jdk/compare/78454b69da1434da18193d32813c59126348c9ea...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@chhagedorn, @vnkozlov) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 15, 2022
@zzambers
Copy link
Contributor Author

zzambers commented Nov 15, 2022

@chhagedorn Thanks for review
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 15, 2022
@openjdk
Copy link

openjdk bot commented Nov 15, 2022

@zzambers
Your change (at version 81d1ba0) is now ready to be sponsored by a Committer.

@TobiHartmann
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 16, 2022

Going to push as commit 3f2f128.
Since your change was applied there have been 222 commits pushed to the master branch:

  • 6ead2b0: 8296548: Improve MD5 intrinsic for x86_64
  • bd3acbe: 8297089: [BACKOUT] JDK-8297088 Update LCMS to 2.14
  • 6a60d31: 8295369: Update LCMS to 2.14
  • 0cbf084: 8296969: C1: PrintC1Statistics is broken after JDK-8292878
  • f662a06: 8296970: Remove sysThreadAvailableStackWithSlack from hotspot-symbols
  • 7357a1a: 8296889: Race condition when cancelling a request
  • 87530e6: 8296913: Correct enable preview idiom in JdbLastErrorTest.java
  • fafe682: 8295861: get rid of list argument in debug agent's removeNode() API
  • 216c6f6: 8294881: test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003/TestDescription.java fails
  • 6aef3a4: 8262435: Clarify the behavior of a few inherited ZipInputStream methods
  • ... and 212 more: https://git.openjdk.org/jdk/compare/78454b69da1434da18193d32813c59126348c9ea...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 16, 2022
@openjdk openjdk bot closed this Nov 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 16, 2022
@openjdk
Copy link

openjdk bot commented Nov 16, 2022

@TobiHartmann @zzambers Pushed as commit 3f2f128.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@zzambers
Copy link
Contributor Author

@TobiHartmann @vnkozlov Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
4 participants