New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8295952: Problemlist existing compiler/rtm tests also on x86 #10875
Conversation
👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into |
@zzambers To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label hotspot |
@zzambers |
failures in GHA do not seem to be connected to this change |
/label add hotspot-compiler |
@chhagedorn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and trivial!
@zzambers This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 216 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@chhagedorn, @vnkozlov) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@chhagedorn Thanks for review |
/sponsor |
Going to push as commit 3f2f128.
Your commit was automatically rebased without conflicts. |
@TobiHartmann @zzambers Pushed as commit 3f2f128. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
@TobiHartmann @vnkozlov Thanks |
Problemlist should be extended so that existing compiler/rtm entries include x86 (32-bit) intel builds as well, as these are also affected.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10875/head:pull/10875
$ git checkout pull/10875
Update a local copy of the PR:
$ git checkout pull/10875
$ git pull https://git.openjdk.org/jdk pull/10875/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10875
View PR using the GUI difftool:
$ git pr show -t 10875
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10875.diff