New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8285932 Implementation of JEP 430 String Templates (Preview) #10889
Closed
Closed
Changes from 1 commit
Commits
Show all changes
89 commits
Select commit
Hold shift + click to select a range
32381da
Initial merge of string templates
JimLaskey af87554
Merge branch 'master' into 8285932
JimLaskey cf9a060
Add MakeConcatWithTemplate and StringConcatItem tests
JimLaskey 7356bb2
Merge branch 'master' into 8285932
JimLaskey 95c9820
Clean up tests
JimLaskey 97b72de
Rename TemplateProcessor
JimLaskey beb3975
Javadoc mistakes
JimLaskey e29719e
Rename to ValidatingProcessor
JimLaskey c9748b3
Merge branch 'master' into 8285932
JimLaskey b62f9b8
Added RAW template processor
JimLaskey a4469ec
Add valueGetters method
JimLaskey 0cfd07f
Correct implNote
JimLaskey da07f3a
Force processor before template string expression
JimLaskey 7b2011a
Tabs to spaces
JimLaskey 2648596
Move StringConcatItem to FormatConcatItem
JimLaskey 20f54de
Update TemplateRuntime::combine
JimLaskey 347df71
Remove .orig file
JimLaskey 15e32a7
Requested changes
JimLaskey d30e6ef
Requested changes #2
JimLaskey 75fcc49
Move template bootstrap
JimLaskey 6d1d902
Add @SafeVarargs declarations
JimLaskey 6cea084
Merge branch 'master' into 8285932
JimLaskey c81d0d2
Requested changes #3
JimLaskey 7610dd0
Requested changes #4
JimLaskey 2cf00ca
Internalize TemplateSupport
JimLaskey 7f3d652
Requested changes #5
JimLaskey b35ed66
Internalize FormatConcatItem
JimLaskey c8412eb
Merge branch 'master' into 8285932
JimLaskey 1af7dc1
Switch from anonymous classes to carrier based StringTemplate implem…
JimLaskey 39c63c0
Clean up new StringTemplate creation
JimLaskey ac5402e
Requested changes #5
JimLaskey 2dc2cad
Requested changes #7
JimLaskey c15142a
Merge branch 'master' into 8285932
JimLaskey 59d7037
Wrong line separator
JimLaskey e4812ee
Wrong line separator
JimLaskey dcceb67
Requested changes #8
JimLaskey 9fdd999
Update StringTemplate javadoc
JimLaskey 2edc792
Requested changes #8
JimLaskey 89f9ac0
Requested changes #9
JimLaskey fc67965
Requested changes #10
JimLaskey c51f88c
Typo
JimLaskey f2562ab
Requested changes #11
JimLaskey da3ea20
Seal Digits
JimLaskey e9f52f2
Requested changes #12
JimLaskey 09f1ac0
Update @since
JimLaskey 69efbb4
FormatProcessor changes
JimLaskey 581e0f7
Merge branch 'master' into 8285932
JimLaskey 098467f
Merge branch 'master' into 8285932
JimLaskey 57638f9
Update to JDK 21
JimLaskey 264120a
Merge branch 'master' into 8285932
JimLaskey 665cded
Bring up to date
JimLaskey 8f5ad0a
CSR review
JimLaskey 5fab46c
Merge branch 'master' into 8285932
JimLaskey 5a031bd
Minor correction to javadoc
JimLaskey 95d219a
Merge branch 'master' into 8285932
JimLaskey 89806d4
Merge branch 'master' into 8285932
JimLaskey 85cc7ef
Tighten up reporting of string template errors (fewer messages)
JimLaskey 67c77e0
Javadoc corrections and bug fix for StringTemplate::combine
JimLaskey 5d79f65
Merge branch 'master' into 8285932
JimLaskey e104926
Merge branch 'master' into 8285932
JimLaskey 50456b3
Correction
JimLaskey d6947fd
Merge branch 'master' into 8285932
JimLaskey ead4342
Rename StringTemplate classes
JimLaskey 9ba6400
Tidy javadoc
JimLaskey 6f95d95
Review recommended changes
JimLaskey 96752c6
Clean up list construction
JimLaskey 58eeb31
Requested review changes.
JimLaskey c9696c2
Update StringTemplate.combine javadoc
JimLaskey 3e1cc74
Merge branch 'master' into 8285932
JimLaskey 67ffbcc
Update combine example
JimLaskey 6274eb3
RuntimeException is the only exception type that can is deduced from …
JimLaskey 4c6d70d
Recommended changes
JimLaskey 62eadb8
Clean up Error handling
JimLaskey 6016deb
Change MAX_INDY_CONCAT_ARG_SLOTS to be updatable.
JimLaskey f1b187a
Merge branch 'master' into 8285932
JimLaskey 5e0dfce
Recommended changes
JimLaskey 69f49bd
Remove preview feature on package private java.util.Digits
JimLaskey 961a541
HexDigits -> OctalDigits
JimLaskey f27ad70
Typo
JimLaskey 70c215c
Remove @PeviewFeature(feature=PreviewFeature.Feature.STRING_TEMPLATES…
JimLaskey 2e3f2ce
Tidy up
JimLaskey c6d943c
Spacing
JimLaskey 5c18223
Merge branch 'master' into 8285932
JimLaskey fb406d2
CSR recommendations
JimLaskey 53f6280
Requested changes
JimLaskey 8e83e10
Recommended changes
JimLaskey 2ac6252
Dangling <p>
JimLaskey f4f2661
Merge branch 'master' into 8285932
JimLaskey 6b09d2e
Update TestJavacTaskScanner.java
JimLaskey File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be exposed? FormatProcessor is the only permitted type, so javac could detect that (or have an internal list of supported optimized processors).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not worth changing at this point. The plan is to replace with TemplateProcessorFactories.