New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8293785: Add a jtreg test for TraceOptoParse #10898
Conversation
👋 Welcome back xpbob! A progress list of the required criteria for merging this PR into |
Sorry for the late. Is this the jtreg test discussed here: #10262 (review) ? @chhagedorn Thanks. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Bob
Is this the jtreg test discussed here: #10262 (review) ? @chhagedorn
Yes, exactly. Thanks for adding such a sanity test!
* @test | ||
* @bug 8293785 | ||
* @summary test for -XX:+TraceOptoParse | ||
* @requires vm.debug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should also add vm.compiler2.enabled
as the flag is C2 specific:
* @requires vm.debug | |
* @requires vm.debug & vm.compiler2.enabled |
Thanks for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good!
@xpbob This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@chhagedorn, @DamonFool) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too.
Thanks for adding this test.
@chhagedorn @DamonFool |
/integrate |
/sponsor |
Going to push as commit 823fd4a.
Your commit was automatically rebased without conflicts. |
@DamonFool @xpbob Pushed as commit 823fd4a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Add a jtreg test for TraceOptoParse after JDK-8293774
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10898/head:pull/10898
$ git checkout pull/10898
Update a local copy of the PR:
$ git checkout pull/10898
$ git pull https://git.openjdk.org/jdk pull/10898/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10898
View PR using the GUI difftool:
$ git pr show -t 10898
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10898.diff