Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293785: Add a jtreg test for TraceOptoParse #10898

Closed
wants to merge 2 commits into from

Conversation

xpbob
Copy link
Contributor

@xpbob xpbob commented Oct 28, 2022

Add a jtreg test for TraceOptoParse after JDK-8293774


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10898/head:pull/10898
$ git checkout pull/10898

Update a local copy of the PR:
$ git checkout pull/10898
$ git pull https://git.openjdk.org/jdk pull/10898/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10898

View PR using the GUI difftool:
$ git pr show -t 10898

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10898.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2022

👋 Welcome back xpbob! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@xpbob
Copy link
Contributor Author

xpbob commented Oct 28, 2022

Sorry for the late.

Is this the jtreg test discussed here: #10262 (review) ? @chhagedorn

Thanks.
Best regards,
Bob

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 28, 2022
@openjdk
Copy link

openjdk bot commented Oct 28, 2022

@xpbob The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Oct 28, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 28, 2022

Webrevs

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Bob

Is this the jtreg test discussed here: #10262 (review) ? @chhagedorn

Yes, exactly. Thanks for adding such a sanity test!

* @test
* @bug 8293785
* @summary test for -XX:+TraceOptoParse
* @requires vm.debug
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also add vm.compiler2.enabled as the flag is C2 specific:

Suggested change
* @requires vm.debug
* @requires vm.debug & vm.compiler2.enabled

@xpbob
Copy link
Contributor Author

xpbob commented Oct 28, 2022

Thanks for review.
@chhagedorn
The code has been updated

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good!

@openjdk
Copy link

openjdk bot commented Oct 28, 2022

@xpbob This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293785: Add a jtreg test for TraceOptoParse

Reviewed-by: chagedorn, jiefu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 754bd53: 8296030: compiler/c2/irTests/TestVectorizeTypeConversion.java fails with release VMs after JDK-8291781
  • 1fdbb1b: 8295926: RISC-V: C1: Fix LIRGenerator::do_LibmIntrinsic
  • cf5546b: 8291336: Add ideal rule to convert floating point multiply by 2 into addition
  • 4b89fce: 8291781: assert(!is_visited) failed: visit only once with -XX:+SuperWordRTDepCheck
  • d5d3424: 8295405: Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@chhagedorn, @DamonFool) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 28, 2022
Copy link
Member

@DamonFool DamonFool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too.
Thanks for adding this test.

@xpbob
Copy link
Contributor Author

xpbob commented Oct 28, 2022

@chhagedorn @DamonFool
Thanks for review.

@xpbob
Copy link
Contributor Author

xpbob commented Oct 28, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 28, 2022
@openjdk
Copy link

openjdk bot commented Oct 28, 2022

@xpbob
Your change (at version c23a321) is now ready to be sponsored by a Committer.

@DamonFool
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 28, 2022

Going to push as commit 823fd4a.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 754bd53: 8296030: compiler/c2/irTests/TestVectorizeTypeConversion.java fails with release VMs after JDK-8291781
  • 1fdbb1b: 8295926: RISC-V: C1: Fix LIRGenerator::do_LibmIntrinsic
  • cf5546b: 8291336: Add ideal rule to convert floating point multiply by 2 into addition
  • 4b89fce: 8291781: assert(!is_visited) failed: visit only once with -XX:+SuperWordRTDepCheck
  • d5d3424: 8295405: Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 28, 2022
@openjdk openjdk bot closed this Oct 28, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 28, 2022
@openjdk
Copy link

openjdk bot commented Oct 28, 2022

@DamonFool @xpbob Pushed as commit 823fd4a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants