New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8296188: Update style and header in JDWP Protocol spec and JVMTI spec #10957
JDK-8296188: Update style and header in JDWP Protocol spec and JVMTI spec #10957
Conversation
Update style and header in JDWP Protocol spec and JVMTI spec
👋 Welcome back jjg! A progress list of the required criteria for merging this PR into |
@jonathan-gibbons The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@jonathan-gibbons This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@jonathan-gibbons Pushed as commit fd60036. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thank you for the spec improvements!
Serguei
Please review a simple makefile-only update to inject the standard stylesheet and navigation header into the two JDK specifications that are generated as HTML files in the
gensrc
directory, to bring these docs in line with the rest of the specs documents.Generated docs at:
The JVM TI spec has a list of links at the beginning, in bold. This is not a CSS issue ... it is in the HTML, generated by XSL scripts. Ideally, the list should be in a separate
<nav>
element and the<b>
tags removed, and maybe the style revised using local CSS. But that is a separate issue.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10957/head:pull/10957
$ git checkout pull/10957
Update a local copy of the PR:
$ git checkout pull/10957
$ git pull https://git.openjdk.org/jdk pull/10957/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10957
View PR using the GUI difftool:
$ git pr show -t 10957
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10957.diff