Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295984: Remove unexpected JShell feature #10979

Closed
wants to merge 1 commit into from

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Nov 4, 2022

This patch patches JShell to not have the ability to run URL specified on the command line. Please also review the CSR: https://bugs.openjdk.org/browse/JDK-8296326

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request to be approved

Issues

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10979/head:pull/10979
$ git checkout pull/10979

Update a local copy of the PR:
$ git checkout pull/10979
$ git pull https://git.openjdk.org/jdk pull/10979/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10979

View PR using the GUI difftool:
$ git pr show -t 10979

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10979.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 4, 2022

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Nov 4, 2022
@openjdk
Copy link

openjdk bot commented Nov 4, 2022

@lahodaj The following label will be automatically applied to this pull request:

  • kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the kulla kulla-dev@openjdk.org label Nov 4, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 4, 2022

Webrevs

Copy link
Member

@sormuras sormuras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sundararajana sundararajana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Nov 16, 2022
@openjdk
Copy link

openjdk bot commented Nov 16, 2022

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295984: Remove unexpected JShell feature

Reviewed-by: cstein, sundar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 169 new commits pushed to the master branch:

  • 95c390e: 8296956: [JVMCI] HotSpotResolvedJavaFieldImpl.getIndex returns wrong value
  • 68d3ed5: 8296442: EncryptedPrivateKeyInfo can be created with an uninitialized AlgorithmParameters
  • 37848a9: 8296967: [JVMCI] rationalize relationship between getCodeSize and getCode in ResolvedJavaMethod
  • b3ef337: 8296960: [JVMCI] list HotSpotConstantPool.loadReferencedType to ConstantPool
  • f0474b8: 8283238: make/scripts/compare.sh should show the diff when classlist does not match
  • 04a4d34: 8297006: JFR: AbstractEventStream should not hold thread instance
  • 5db1b58: 8296961: [JVMCI] Access to j.l.r.Method/Constructor/Field for ResolvedJavaMethod/ResolvedJavaField
  • 4ce4f38: 8296958: [JVMCI] add API for retrieving ConstantValue attributes
  • 8c26d02: 8295315: [REDO] 8276687 Remove support for JDK 1.4.1 PerfData shared memory files
  • 8752bb4: 8296818: Enhance JMH tests java/security/Signatures.java
  • ... and 159 more: https://git.openjdk.org/jdk/compare/b685fc2de4d2847de2d1efaab2890646257ea6d3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 16, 2022
@lahodaj
Copy link
Contributor Author

lahodaj commented Nov 23, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Nov 23, 2022

Going to push as commit bc59f2a.
Since your change was applied there have been 283 commits pushed to the master branch:

  • 0d93ab9: 8297000: [jib] Add more friendly warning for proxy issues
  • 5b3d86f: 8297230: Update Marlin2D to 0.9.4.6
  • f4b5065: 8297435: Remove unused CompactibleSpaceClosure
  • bde0e35: 8297142: jdk/jfr/event/runtime/TestShutdown.java fails on Linux ppc64le and Linux aarch64
  • f26bd4e: 8297350: Update JMH devkit to 1.36
  • 470f342: 8296904: Improve handling of macos xcode toolchain
  • b4bd287: 8191406: [hidpi] sun/java2d/SunGraphics2D/DrawImageBilinear.java test fails
  • 412b436: 6201035: Document NPE for passing null insets to constructors and methods of several javax.swing.border.* classes
  • faf48e6: 8296329: jar validator doesn't account for minor class file version
  • 09f70da: 8296265: Use modern HTML in the JVMTI spec
  • ... and 273 more: https://git.openjdk.org/jdk/compare/b685fc2de4d2847de2d1efaab2890646257ea6d3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 23, 2022
@openjdk openjdk bot closed this Nov 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 23, 2022
@openjdk
Copy link

openjdk bot commented Nov 23, 2022

@lahodaj Pushed as commit bc59f2a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated kulla kulla-dev@openjdk.org
3 participants