Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296479: Remove stray comment about POST_STRIP_CMD #11021

Closed
wants to merge 1 commit into from

Conversation

magicus
Copy link
Member

@magicus magicus commented Nov 7, 2022

The variable POST_STRIP_CMD has been removed, but not all comments about it


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296479: Remove stray comment about POST_STRIP_CMD

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11021/head:pull/11021
$ git checkout pull/11021

Update a local copy of the PR:
$ git checkout pull/11021
$ git pull https://git.openjdk.org/jdk pull/11021/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11021

View PR using the GUI difftool:
$ git pr show -t 11021

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11021.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 7, 2022

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 7, 2022
@openjdk
Copy link

openjdk bot commented Nov 7, 2022

@magicus The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Nov 7, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 7, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 7, 2022

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296479: Remove stray comment about POST_STRIP_CMD

Reviewed-by: iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 3baad06: 8295953: Use enhanced-for cycle instead of Enumeration in sun.security
  • ba303c0: 8295893: Improve printing of Constant Pool Cache Entries
  • f8b2574: 8296137: diags-examples.xml is broken
  • 00d22f6: 8279164: Disable TLS_ECDH_* cipher suites

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 7, 2022
@magicus
Copy link
Member Author

magicus commented Nov 7, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Nov 7, 2022

Going to push as commit b29817a.
Since your change was applied there have been 5 commits pushed to the master branch:

  • b6ea69c: 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing
  • 3baad06: 8295953: Use enhanced-for cycle instead of Enumeration in sun.security
  • ba303c0: 8295893: Improve printing of Constant Pool Cache Entries
  • f8b2574: 8296137: diags-examples.xml is broken
  • 00d22f6: 8279164: Disable TLS_ECDH_* cipher suites

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 7, 2022
@openjdk openjdk bot closed this Nov 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 7, 2022
@openjdk
Copy link

openjdk bot commented Nov 7, 2022

@magicus Pushed as commit b29817a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@magicus magicus deleted the remove-POST_STRIP_CMD branch November 21, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
2 participants