8296718: Refactor bootstrap Test Common Functionalities to test/lib/Utils

[bwhuang-us]

There is no new changes in the open portion of JDK, but extracting common functionalities in bootstrap Utils to test/lib/Utils which can be used in the closed part.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8296718: Refactor bootstrap Test Common Functionalities to test/lib/Utils

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)
• Kevin Walls (@kevinjwalls - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11029/head:pull/11029
$ git checkout pull/11029

Update a local copy of the PR:
$ git checkout pull/11029
$ git pull https://git.openjdk.org/jdk pull/11029/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11029

View PR using the GUI difftool:
$ git pr show -t 11029

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11029.diff

[bridgekeeper]

👋 Welcome back bhuang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bwhuang-us The following labels will be automatically applied to this pull request:

• core-libs
• hotspot-runtime
• jmx
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (191cd5ca)
• 00: Full (98a7188e)

[sspitsyn]

The refactoring looks pretty good.
But I have a couple of questions.
Q1: The method grantAccess is converted to the util method grantFileAccess and it does not look the same. Could you, please, explain what are the changes?
Q2: I'm confused about conversion of the shell tests. Your fix does not convert any shell test. Also, I do not see any changes to the shell ile test/jdk/sun/management/jmxremote/bootstrap/ReadWriteForbidsCreateTest.sh listed in the enhancement. Can you explain, please?

[bwhuang-us]

Hi @sspitsyn, the methods grantAccess and grantFileAccess are almost identical except for the parameter AccessControl access being changed to a boolean which is used to indicate user access or full access. There is also a minor change in building a new ACL entry out of the original entry.

For your Q2 , it is in closed part of JDK. Please see the JBS ticket for the PR link.

[sspitsyn]

I've placed a couple of comments.
Otherwise, it looks okay to me.
Thanks,
Serguei

[sspitsyn]

Thank you for the update.
Looks good.
Thanks,
Serguei

[kevinjwalls]

Looks ok! 8-)

[bwhuang-us]

/integrate

[openjdk]

@bwhuang-us This pull request has not yet been marked as ready for integration.

[bwhuang-us]

It seems there is an integration issue with this PR as the JBS ticket is marked as confidential. I will open a new ticket for this change.

[bwhuang-us]

/issue JDK-8296718

[openjdk]

@bwhuang-us This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296718: Refactor bootstrap Test Common Functionalities to test/lib/Utils

Reviewed-by: sspitsyn, kevinw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 58 new commits pushed to the master branch:

• 17e3412: 8296615: use of undeclared identifier 'IPV6_DONTFRAG'
• a5d838c: 8296591: Signature benchmark
• fa8a866: 8296675: Exclude linux-aarch64 in NSS tests
• d4376f8: 8296406: ChainingConstructors jtreg test reduce code duplication
• 4a0093c: 8294362: UL: Replace the internal usage of manual buffers with stringStream in LogSelection
• fef68bb: 8296515: RISC-V: Small refactoring for MaxReductionV/MinReductionV/AddReductionV node implementation
• 82cbfb5: 8296140: Drop unused field java.util.Calendar.DATE_MASK
• fd83764: 8296239: ISO 4217 Amendment 174 Update
• d9b25e8: 8296426: x86: Narrow UseAVX and UseSSE flags
• 8146e1a: 8296347: Memory leak from ClassPathDirEntry::_dir
• ... and 48 more: https://git.openjdk.org/jdk/compare/a8070fba21e7307269b988d38e30133cc2d3889f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@bwhuang-us This issue is referenced in the PR title - it will now be updated.

[bwhuang-us]

/integrate

[openjdk]

Going to push as commit cc8bf95.
Since your change was applied there have been 58 commits pushed to the master branch:

• 17e3412: 8296615: use of undeclared identifier 'IPV6_DONTFRAG'
• a5d838c: 8296591: Signature benchmark
• fa8a866: 8296675: Exclude linux-aarch64 in NSS tests
• d4376f8: 8296406: ChainingConstructors jtreg test reduce code duplication
• 4a0093c: 8294362: UL: Replace the internal usage of manual buffers with stringStream in LogSelection
• fef68bb: 8296515: RISC-V: Small refactoring for MaxReductionV/MinReductionV/AddReductionV node implementation
• 82cbfb5: 8296140: Drop unused field java.util.Calendar.DATE_MASK
• fd83764: 8296239: ISO 4217 Amendment 174 Update
• d9b25e8: 8296426: x86: Narrow UseAVX and UseSSE flags
• 8146e1a: 8296347: Memory leak from ClassPathDirEntry::_dir
• ... and 48 more: https://git.openjdk.org/jdk/compare/a8070fba21e7307269b988d38e30133cc2d3889f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bwhuang-us Pushed as commit cc8bf95.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.