8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM

[prsadhuk]

Test intermittently fails in VM citing "Tree is not editing". Seems to be problem with mouse clicks not getting registered properly..
Similar test test/jdk/javax/swing/JTable/6263446/bug6263446.java is not affected, so made the test similar to it by using same safeguard using Robot.waitForIdle() and modifying clickpoint to tree cell midpoint.

Several iterations of the test pass in the OCI VM and all other physical platforms (link in JBS)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM

Reviewers

• Tejesh R (@TejeshR13 - Committer) ⚠️ Review applies to 6a00a87c
• Phil Race (@prrace - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11057/head:pull/11057
$ git checkout pull/11057

Update a local copy of the PR:
$ git checkout pull/11057
$ git pull https://git.openjdk.org/jdk pull/11057/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11057

View PR using the GUI difftool:
$ git pr show -t 11057

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11057.diff

[bridgekeeper]

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prsadhuk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (a1ae319b)
• 00: Full (6a00a87c)

[jayathirthrao]

any particular reason for decreasing length of string?

[prsadhuk]

Yes, as I mentioned to make it same like JTable/6263446/bug6263446.java which has not failed in these OCI systems at all as the cause of this test failure in OCI system was not making any sense but in my local ubutu20.04 system ,it fails once in a while for not able to select the string which is done in the testcase by mouse clicks, so more characters can result in failure in selection if mouse clicks is not getting registered properly...
Reducing characters does not hamper testcase which can still be used to test JDK-6263446 regression

[prrace]

So it now passes 100% of the time on the OCI systems ?

[prsadhuk]

So it now passes 100% of the time on the OCI systems ?

At least in my testing, links of those OCI jobs have been put in JBS too

[prsadhuk]

Just to reiterate, I am not sure why it is failing in OCI systems as I am not able to reproduce in OCI...one time I reproduce it is bcoz of screen lock...So I added this stability checks and made it similar to JTable/6263446.java which results it in passing in OCI in several CI jobs that I gave (link in JBS)...I think we should probably give this stability fixes it a try

[prrace]

This test will need to be monitored

[openjdk]

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM

Reviewed-by: tr, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 103 new commits pushed to the master branch:

• 39dda24: 8157173: [macosx] java/awt/Robot/ModifierRobotKey/ModifierRobotKeyTest.java fails
• 51f690d: 8297134: Add a @sealedGraph tag to InetAddress
• 3eb6d0e: 8291991: Adjust the "shared class paths mismatch" message if class path logging is enabled
• eac26f4: 8296709: WARNING: JNI call made without checking exceptions
• 4946737: 8297047: IGV: graphContent not set when opening a new tab
• 8b1ff9e: 8297132: BACKOUT JDK-8296889: Race condition when cancelling a request
• e72b0ac: 8296429: Remove os::supports_sse
• 813b223: 8296926: Sort include lines of files in the include/ directory
• 8cdcec4: 8296774: Removed default MEMFLAGS value from CHeapBitMap
• c3b285a: 8296916: RISC-V: Move some small macro-assembler functions to header file
• ... and 93 more: https://git.openjdk.org/jdk/compare/fef68bbaf6de7e0d4be311a5f3648c16548c5b4d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[prsadhuk]

/integrate

[openjdk]

Going to push as commit dd9aa72.
Since your change was applied there have been 117 commits pushed to the master branch:

• cc44419: 8295407: C2 crash: Error: ShouldNotReachHere() in multiple vector tests with -XX:-MonomorphicArrayCheck -XX:-UncommonNullCast
• e2269fd: 8296968: Update langtools tests to use @enablePreview
• 2159170: 8296453: Simplify resource_area uses in ClassPathDirEntry::open_stream
• 95c390e: 8296956: [JVMCI] HotSpotResolvedJavaFieldImpl.getIndex returns wrong value
• 68d3ed5: 8296442: EncryptedPrivateKeyInfo can be created with an uninitialized AlgorithmParameters
• 37848a9: 8296967: [JVMCI] rationalize relationship between getCodeSize and getCode in ResolvedJavaMethod
• b3ef337: 8296960: [JVMCI] list HotSpotConstantPool.loadReferencedType to ConstantPool
• f0474b8: 8283238: make/scripts/compare.sh should show the diff when classlist does not match
• 04a4d34: 8297006: JFR: AbstractEventStream should not hold thread instance
• 5db1b58: 8296961: [JVMCI] Access to j.l.r.Method/Constructor/Field for ResolvedJavaMethod/ResolvedJavaField
• ... and 107 more: https://git.openjdk.org/jdk/compare/fef68bbaf6de7e0d4be311a5f3648c16548c5b4d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prsadhuk Pushed as commit dd9aa72.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.