8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError

[TejeshR13]

Observation found when JFileChooser is instantiated in WindowsLookAndFeel which invokes getSystemIcon() from WindowsFileChooserUI class. Could not find the exact root cause so predicting it to be an issue with icons not loaded where resolutionVariants map is empty in _public Image getResolutionVariant(double width, double height) _. Hence proposing a null check before accessing getWidth(). Fix is tested in CI system.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11079/head:pull/11079
$ git checkout pull/11079

Update a local copy of the PR:
$ git checkout pull/11079
$ git pull https://git.openjdk.org/jdk pull/11079/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11079

View PR using the GUI difftool:
$ git pr show -t 11079

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11079.diff

[TejeshR13]

@bug JDK-8293862

[bridgekeeper]

👋 Welcome back tr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TejeshR13 The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (cef689c8)

[TejeshR13]

@azuev-java Can please share your comments on the PR.

[mrserb]

I am pretty sure that the NPE reported recently in the comment in JBS is unrelated to the AssertionError reported initially. It is better to file separate issue.

[TejeshR13]

I am pretty sure that the NPE reported recently in the comment in JBS is unrelated to the AssertionError reported initially. It is better to file separate issue.

There is a separate JBS for the NPE issue also, since the recent observations were linked to that I thought it be better as a defensive fix for this too.

[TejeshR13]

Created separate PR which has the exact observation for a bug - [JDK-8293862] (https://bugs.openjdk.org/browse/JDK-8293862). Closing this PR.